[edk2-devel] [Patch V3 0/8] Resolve Quark build and boot issues

Liming Gao liming.gao at intel.com
Sun May 5 05:23:57 UTC 2019


The change in MdePkg is good. Reviewed-by: Liming Gao <liming.gao at intel.com>

>-----Original Message-----
>From: Kinney, Michael D
>Sent: Wednesday, May 01, 2019 3:31 AM
>To: devel at edk2.groups.io
>Cc: Steele, Kelly <kelly.steele at intel.com>; Gao, Liming
><liming.gao at intel.com>; Dong, Eric <eric.dong at intel.com>; Ni, Ray
><ray.ni at intel.com>; Laszlo Ersek <lersek at redhat.com>
>Subject: [Patch V3 0/8] Resolve Quark build and boot issues
>
>New in V3
>=========
>* Remove change to MpInitLib to avoid use of MSR_IA32_APIC_BASE.  That
>change
>  was not safe because an AP could call the PCD Protocol/PPI.
>* Add new MpInitLibUp for uni-processor platforms.
>* Update Quark DSC files to use MpInitLibUp for uni-processor platforms.
>* Add missing CpuLub library class to the CpuMpPei INF file
>
>New in V2
>=========
>* Add PcdSpeculationBarrierType to select between LFENCE, CPUID, and no
>  operation in the x86 implementation of the BaseLib function
>  SpeculationBarrier().
>* Set PcdSpeculationBarrierType to CPUID on Quark platforms.
>
>This series of patches resolves a few issues with building
>and booting Quark platforms.
>
>* Resolve name collision from API added to ResetSystemLib
>* Set SMRAM region to UC when SMRAM region is closed
>* Do no use LFENCE if CPU does not support SSE2
>* Avoid MSR_IA32_APIC_BASE if there is only one CPU
>
>Cc: Kelly Steele <kelly.steele at intel.com>
>Cc: Liming Gao <liming.gao at intel.com>
>Cc: Eric Dong <eric.dong at intel.com>
>Cc: Ray Ni <ray.ni at intel.com>
>Cc: Laszlo Ersek <lersek at redhat.com>
>Signed-off-by: Michael D Kinney <michael.d.kinney at intel.com>
>
>Michael D Kinney (8):
>  MdePkg: Add PcdSpeculationBarrierType
>  MdePkg/BaseLib: Use PcdSpeculationBarrierType
>  QuarkPlatformPkg: Set PcdSpeculationBarrierType to CPUID
>  UefiCpuPkg/MpInitLibUp: Add uniprocessor MpInitLib
>  UefiCPuPkg/CpuMpPei: Add missing CpuLib class
>  QuarkPlatformPkg: Use uniprocessor MpInitLibUp
>  QuarkSocPkg/SmmAccessDxe: Set region to UC on SMRAM close
>  QuarkPlatformPkg/PlatformInit: Resolve ResetSystemLib name collision
>
> MdePkg/Library/BaseLib/BaseLib.inf            |   1 +
> .../Library/BaseLib/X86SpeculationBarrier.c   |   8 +-
> MdePkg/MdePkg.dec                             |   9 +
> MdePkg/MdePkg.uni                             |   8 +
> .../Pei/PlatformInit/MemoryCallback.c         |   6 +-
> .../Pei/PlatformInit/PlatformEarlyInit.h      |   4 +-
> QuarkPlatformPkg/Quark.dsc                    |  10 +-
> QuarkPlatformPkg/QuarkMin.dsc                 |   8 +-
> .../Smm/Dxe/SmmAccessDxe/SmmAccess.inf        |   3 +-
> .../Smm/Dxe/SmmAccessDxe/SmmAccessDriver.c    |  18 +-
> .../Smm/Dxe/SmmAccessDxe/SmmAccessDriver.h    |   3 +-
> UefiCpuPkg/CpuMpPei/CpuMpPei.inf              |   3 +-
> UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c  | 407
>++++++++++++++++++
> .../Library/MpInitLibUp/MpInitLibUp.inf       |  37 ++
> .../Library/MpInitLibUp/MpInitLibUp.uni       |  14 +
> UefiCpuPkg/UefiCpuPkg.dsc                     |   3 +-
> 16 files changed, 525 insertions(+), 17 deletions(-)
> create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c
> create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf
> create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.uni
>
>--
>2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39990): https://edk2.groups.io/g/devel/message/39990
Mute This Topic: https://groups.io/mt/31424365/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list