[edk2-devel] [PATCH v1 1/1] ShellPkg: Display VENDOR_ID in ASCII when parsing PPTT

[Sami Mujawar]

Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

Regards,

Sami Mujawar

-----Original Message-----
From: Krzysztof Koch <krzysztof.koch at arm.com> 
Sent: 08 May 2019 02:14 PM
To: devel at edk2.groups.io
Cc: jaben.carsey at intel.com; ray.ni at intel.com; Sami Mujawar <Sami.Mujawar at arm.com>; Girish Pathak <Girish.Pathak at arm.com>; Pierre Gondois <Pierre.Gondois at arm.com>; Matteo Carlini <Matteo.Carlini at arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt at arm.com>; nd <nd at arm.com>
Subject: [PATCH v1 1/1] ShellPkg: Display VENDOR_ID in ASCII when parsing PPTT

The ID Type Structure (Type 2) inside the Processor Properties Topology Table (PPTT) has a VENDOR_ID field which identifies the node vendor. The approved values are listed in the ACPI ID Registry and they are meant to be interpreted as arrays of ASCII characters.

This change to the acpiview parser for PPTT aims to reflect that.

Signed-off-by: Krzysztof Koch <krzysztof.koch at arm.com>
---

The changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/woa_500_print_vendor_id_ascii_v1

Notes:
    v1:
      - Display VENDOR_ID in ASCII [Krzysztof]

 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
index c6588a12b4639f2bf6f0953d98410befbab66e31..ffcc53cda7d8df1d2f0787c1b4b1d30de87ac854 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttPars
+++ er.c
@@ -150,7 +150,7 @@ STATIC CONST ACPI_PARSER IdStructureParser[] = {
   {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
   {L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL},
 
-  {L"VENDOR_ID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
+  {L"VENDOR_ID", 4, 4, NULL, Dump4Chars, NULL, NULL, NULL},
   {L"LEVEL_1_ID", 8, 8, L"0x%x", NULL, NULL, NULL, NULL},
   {L"LEVEL_2_ID", 8, 16, L"0x%x", NULL, NULL, NULL, NULL},
   {L"MAJOR_REV", 2, 24, L"0x%x", NULL, NULL, NULL, NULL},
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40355): https://edk2.groups.io/g/devel/message/40355
Mute This Topic: https://groups.io/mt/31543018/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-