[edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation

[Dandan Bi]

Hi Krzysztof Koch,

You patch is good to me.
Reviewed-by: Bi Dandan <dandan.bi at intel.com>

I think maintainers will help push soon if they don't have additional comments.

I have just one comments for future patches since this one is small and clear.
Could you help file a Bugzilla (if not have one)to track the issue and add the Bugzilla link into the patch if you submit patch to edk2?  Thanks in advance for cooperation and contribution.

Thanks,
Dandan

> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
> Krzysztof Koch
> Sent: Wednesday, May 15, 2019 4:24 PM
> To: devel at edk2.groups.io; Carsey, Jaben <jaben.carsey at intel.com>; Ni, Ray
> <ray.ni at intel.com>
> Cc: Sami Mujawar <Sami.Mujawar at arm.com>; nd <nd at arm.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1]
> ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation
> 
> Hi Jaben and Ray,
> 
> It's been a while since I posted this patch. Can I help you in any way to get
> this merged?
> 
> Kind regards,
> 
> Krzysztof Koch
> 
> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar at arm.com>
> Sent: Thursday, May 9, 2019 14:37
> To: devel at edk2.groups.io
> Cc: jaben.carsey at intel.com; ray.ni at intel.com; Matteo Carlini
> <Matteo.Carlini at arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-
> Fitt at arm.com>; nd <nd at arm.com>; Krzysztof Koch
> <Krzysztof.Koch at arm.com>
> Subject: RE: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix
> PPTT cache attributes validation
> 
> Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: Krzysztof Koch <krzysztof.koch at arm.com>
> Sent: 31 January 2019 01:30 PM
> To: edk2-devel at lists.01.org
> Cc: jaben.carsey at intel.com; ray.ni at intel.com; Matteo Carlini
> <Matteo.Carlini at arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-
> Fitt at arm.com>; Sami Mujawar <Sami.Mujawar at arm.com>; nd
> <nd at arm.com>
> Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT
> cache attributes validation
> 
> Removed conditional pre-compiling for ARM CPUs because function
> ValidateCacheAttributes(..) is based on ACPI PPTT specification.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Krzysztof Koch <krzysztof.koch at arm.com>
> Reported-by: Zhichao Gao <zhichao.gao at intel.com>
> ---
> 
> The code can be found at:
> https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1
> 
> Notes:
>     v1:
>     - removed conditional precompilation                    [Krzysztof]
> 
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
> | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> index
> bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bc
> c7b791fcf7d70f3 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> @@ -86,11 +86,9 @@ ValidateCacheAttributes (
>    IN VOID*  Context
>    )
>  {
> -#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64)
>    // Reference: Advanced Configuration and Power Interface (ACPI)
> Specification
>    //            Version 6.2 Errata A, September 2017
>    // Table 5-153: Cache Type Structure
> -
>    UINT8 Attributes;
>    Attributes = *(UINT8*)Ptr;
> 
> @@ -102,7 +100,6 @@ ValidateCacheAttributes (
>        );
>      return;
>    }
> -#endif
>  }
> 
>  /**
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40698): https://edk2.groups.io/g/devel/message/40698
Mute This Topic: https://groups.io/mt/30917572/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-