[edk2-devel] [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

[Ni, Ray]

> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Friday, May 17, 2019 9:13 PM
> To: Ni, Ray <ray.ni at intel.com>; devel at edk2.groups.io
> Cc: Gao, Liming <liming.gao at intel.com>; Andrew Fish <afish at apple.com>;
> Leif Lindholm <leif.lindholm at linaro.org>; Kinney, Michael D
> <michael.d.kinney at intel.com>
> Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Remove Nt32Pkg
> reference after Nt32Pkg is removed
> 
> On 05/17/19 06:57, Ray Ni wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ray Ni <ray.ni at intel.com>
> > Cc: Liming Gao <liming.gao at intel.com>
> > Cc: Andrew Fish <afish at apple.com>
> > Cc: Laszlo Ersek <lersek at redhat.com>
> > Cc: Leif Lindholm <leif.lindholm at linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney at intel.com>
> > ---
> >  Maintainers.txt | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt index
> > 7315241b6e..de0b6a284e 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -1,4 +1,4 @@
> > -EDK II Maintainers
> > +EDK II Maintainers
> 
> I'm commenting after the push, but:
> 
> why was the above line changed?
> 
> More precisely: *how* was it changed? (The diff doesn't indicate.)
> 
> ... A-ha! Looking at the pushed commit
> 147e6e70f2be2d3fdebcb2bd366324a24634d562, I can tell. You added a BOM
> to the beginning to the file.
> 
> Please send a new patch soon, to delete the BOM. (It's a bugfix so it is
> suitable for the soft feature freeze.)

I am a bit curious why I was that stupid to add a BOM in the beginning.
So I investigate further.
Root cause is below line contains a non-ASCII character that may cause
the editor I am using (not sure which one I used to edit the Maintainers.txt)
cleverly converts the file to UTF-8 with BOM.
R: Marc-André Lureau <marcandre.lureau at redhat.com>

I will submit another patch to convert the file to UTF-8 without BOM.

> 
> Thanks
> Laszlo
> 
> >  ==================
> >
> >  This file provides information about the primary maintainers for @@
> > -185,11 +185,6 @@ W:
> > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
> >  M: Siyuan Fu <siyuan.fu at intel.com>
> >  M: Jiaxin Wu <jiaxin.wu at intel.com>
> >
> > -Nt32Pkg
> > -W: https://github.com/tianocore/tianocore.github.io/wiki/Nt32Pkg
> > -M: Ray Ni <ray.ni at intel.com>
> > -M: Hao A Wu <hao.a.wu at intel.com>
> > -
> >  OvmfPkg
> >  W: http://www.tianocore.org/ovmf/
> >  M: Jordan Justen <jordan.l.justen at intel.com>
> >
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40923): https://edk2.groups.io/g/devel/message/40923
Mute This Topic: https://groups.io/mt/31651955/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-