[edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b
Gary Lin
glin at suse.com
Mon May 20 01:48:18 UTC 2019
On Sat, May 18, 2019 at 07:26:35AM +0000, Xiaoyu Lu wrote:
> Gary Lin,
>
> Because I divided commit(PATCH v4 6/7) into two patches. Can I pick your Tested-by tag for the two patches?
>
If there is no functional change, my "Tested-by" is still valid.
I can do the test again for v5 if you like.
BTW, I forgot to state that my "Tested-by" doesn't include "PATCH v4 5/7"
since I didn't build aarch64 aavmf due to lacking of https support.
Thanks,
Gary Lin
> Thanks
> Xiaoyu
> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of Gary Lin
> Sent: Friday, May 17, 2019 5:17 PM
> To: devel at edk2.groups.io; Lu, XiaoyuX <xiaoyux.lu at intel.com>
> Cc: Laszlo Ersek <lersek at redhat.com>; Wang, Jian J <jian.j.wang at intel.com>; Ye, Ting <ting.ye at intel.com>
> Subject: Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b
>
> On Thu, May 16, 2019 at 03:54:51AM -0400, Xiaoyu lu wrote:
> > This series is also available at:
> > https://github.com/xiaoyuxlu/edk2/tree/bz_1089_upgrade_to_openssl_1_1_
> > 1b_v4
> >
> > Changes:
> >
> > (1) CryptoPkgOpensslLib: Modify process_files.pl for upgrading
> > OpenSSL
> >
> > (2) CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl
> > crypto/store/* are excluded.
> > crypto/rand/randfile.c is excluded.
> >
> > (3) CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol
> > issue
> >
> > (4) CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL
> > Disable warnings for buiding OpenSSL_1_1_1b
> >
> > (5) CryptoPkg/OpensslLib: Fix cross-build problem for AARCH64
> >
> > (6) CryptoPkg: Upgrade OpenSSL to 1.1.1b
> > The biggest change is use TSC as entropy source
> > If TSC isn't avaiable, fallback to TimerLib(PerformanceCounter).
> >
> > (7) CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible
> >
> >
> > Verification done for this series:
> > * Https boot in OvmfPkg.
> > * BaseCrypt Library test. (Ovmf, EmulatorPkg)
> >
> My https boot test with ovmf looks good. The connection was rejected as expected when the server certificate wasn't enrolled. The bootloader images were downloaded after adding the certificate, and I can boot into the installation UI in the end.
>
> I skipped the test for aavmf since TLS is still not enabled.
>
> For the series.
> Tested-by: Gary Lin <glin at suse.com>
>
> > Important notice:
> > Nt32Pkg doesn't support TimerLib
> > > TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem
> > > TimerLib|plate.inf
> > So it will failed in Nt32Pkg.
> >
> > Cc: Jian J Wang <jian.j.wang at intel.com>
> > Cc: Ting Ye <ting.ye at intel.com>
> >
> > Laszlo Ersek (1):
> > CryptoPkg/OpensslLib: Fix cross-build problem for AARCH64
> >
> > Xiaoyu Lu (6):
> > CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL
> > CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl
> > CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue
> > CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL
> > CryptoPkg: Upgrade OpenSSL to 1.1.1b
> > CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible
> >
> > CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf | 4 +-
> > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 76 ++++-
> > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 67 ++++-
> > CryptoPkg/Library/Include/CrtLibSupport.h | 13 +-
> > CryptoPkg/Library/Include/openssl/opensslconf.h | 54 +++-
> > CryptoPkg/Library/Include/sys/syscall.h | 11 +
> > CryptoPkg/Library/OpensslLib/buildinf.h | 2 +
> > CryptoPkg/Library/OpensslLib/rand_pool_noise.h | 29 ++
> > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 8 +-
> > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 9 +-
> > .../Library/BaseCryptLib/Hmac/CryptHmacSha256.c | 8 +-
> > CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c | 22 ++
> > CryptoPkg/Library/OpensslLib/ossl_store.c | 17 ++
> > CryptoPkg/Library/OpensslLib/rand_pool.c | 316 +++++++++++++++++++++
> > CryptoPkg/Library/OpensslLib/rand_pool_noise.c | 29 ++
> > CryptoPkg/Library/OpensslLib/rand_pool_noise_tsc.c | 43 +++
> > CryptoPkg/Library/OpensslLib/openssl | 2 +-
> > CryptoPkg/Library/OpensslLib/process_files.pl | 11 +-
> > 18 files changed, 669 insertions(+), 52 deletions(-) create mode
> > 100644 CryptoPkg/Library/Include/sys/syscall.h
> > create mode 100644 CryptoPkg/Library/OpensslLib/rand_pool_noise.h
> > create mode 100644 CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c
> > create mode 100644 CryptoPkg/Library/OpensslLib/ossl_store.c
> > create mode 100644 CryptoPkg/Library/OpensslLib/rand_pool.c
> > create mode 100644 CryptoPkg/Library/OpensslLib/rand_pool_noise.c
> > create mode 100644 CryptoPkg/Library/OpensslLib/rand_pool_noise_tsc.c
> >
> > --
> > 2.7.4
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#40989): https://edk2.groups.io/g/devel/message/40989
Mute This Topic: https://groups.io/mt/31638503/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list