[edk2-devel] [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

[Liming Gao]

Jaben:
  Yes. MdeModulePkg is still required. 

Thanks
Liming
> -----Original Message-----
> From: Carsey, Jaben
> Sent: Tuesday, May 21, 2019 12:35 AM
> To: Gao, Liming <liming.gao at intel.com>; devel at edk2.groups.io
> Cc: Gao, Zhichao <zhichao.gao at intel.com>; Ni, Ray <ray.ni at intel.com>
> Subject: RE: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency
> 
> Netlib class definition and instance are both moving?
> 
> Are these modules using MdeModulePkg for a different lib or can we remove it?
> 
> > -----Original Message-----
> > From: Gao, Liming
> > Sent: Monday, May 20, 2019 6:09 AM
> > To: devel at edk2.groups.io
> > Cc: Gao, Zhichao <zhichao.gao at intel.com>; Ni, Ray <ray.ni at intel.com>;
> > Carsey, Jaben <jaben.carsey at intel.com>
> > Subject: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the
> > package dependency
> > Importance: High
> >
> > NetLib will be moved from MdeModulePkg and NetworkPkg.
> > So, the module that consumes NetLib need to depend on NetworkPkg.dec.
> >
> > Signed-off-by: Liming Gao <liming.gao at intel.com>
> > Cc: Zhichao Gao <zhichao.gao at intel.com>
> > Cc: Ray Ni <ray.ni at intel.com>
> > Cc: Jaben Carsey <jaben.carsey at intel.com>
> > ---
> >  ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf                 | 3
> > ++-
> >
> > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.
> > inf      | 3 ++-
> >  .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> > | 3 ++-
> >  .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
> > | 3 ++-
> >  4 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > index 9d57e59c63..bc13c89a97 100644
> > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > @@ -1,7 +1,7 @@
> >  ##  @file
> >  # Provides Shell 'tftp' standalone application.
> >  #
> > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
> > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
> >  # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR>
> >  #
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> > @@ -31,6 +31,7 @@ [Packages]
> >    MdePkg/MdePkg.dec
> >    ShellPkg/ShellPkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> > +  NetworkPkg/NetworkPkg.dec
> >
> >  [LibraryClasses]
> >    MemoryAllocationLib
> > diff --git
> > a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > d.inf
> > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > d.inf
> > index f23445102a..b0c8e8f84b 100644
> > ---
> > a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > d.inf
> > +++
> > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > d.inf
> > @@ -1,7 +1,7 @@
> >  ##  @file
> >  # Provides Shell 'tftp' dynamic command.
> >  #
> > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
> > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
> >  # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR>
> >  #
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> > @@ -32,6 +32,7 @@ [Packages]
> >    MdePkg/MdePkg.dec
> >    ShellPkg/ShellPkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> > +  NetworkPkg/NetworkPkg.dec
> >
> >  [LibraryClasses]
> >    MemoryAllocationLib
> > diff --git
> > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > mandsLib.inf
> > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > mandsLib.inf
> > index 8054dc6f51..1e6ce63e3e 100644
> > ---
> > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > mandsLib.inf
> > +++
> > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > mandsLib.inf
> > @@ -1,7 +1,7 @@
> >  ##  @file
> >  # Provides shell network1 functions
> >  #
> > -# Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. <BR>
> > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
> >  #
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> >  #
> > @@ -29,6 +29,7 @@ [Packages]
> >    MdePkg/MdePkg.dec
> >    ShellPkg/ShellPkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> > +  NetworkPkg/NetworkPkg.dec
> >
> >  [LibraryClasses]
> >    MemoryAllocationLib
> > diff --git
> > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > mandsLib.inf
> > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > mandsLib.inf
> > index a9ca31a310..9ffcf85248 100644
> > ---
> > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > mandsLib.inf
> > +++
> > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > mandsLib.inf
> > @@ -1,7 +1,7 @@
> >  ##  @file
> >  # Provides shell network2 functions
> >  #
> > -# Copyright (c) 2016, Intel Corporation. All rights reserved. <BR>
> > +# Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved. <BR>
> >  #
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> >  #
> > @@ -29,6 +29,7 @@ [Packages]
> >    MdePkg/MdePkg.dec
> >    ShellPkg/ShellPkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> > +  NetworkPkg/NetworkPkg.dec
> >
> >  [LibraryClasses]
> >    MemoryAllocationLib
> > --
> > 2.13.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41093): https://edk2.groups.io/g/devel/message/41093
Mute This Topic: https://groups.io/mt/31684909/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-