[edk2-devel] [edk2-platforms] [PATCH 2/5] KabylakeSiliconPkg: Casting functions to EFIAPI
Chiu, Chasel
chasel.chiu at intel.com
Tue May 21 02:19:16 UTC 2019
Reviewed-by: Chasel Chiu <chasel.chiu at intel.com>
> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
> Agyeman, Prince
> Sent: Thursday, May 16, 2019 1:36 AM
> To: devel at edk2.groups.io
> Cc: Agyeman, Prince <prince.agyeman at intel.com>; Kubacki, Michael A
> <michael.a.kubacki at intel.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>; Gao, Liming <liming.gao at intel.com>; Sinha,
> Ankit <ankit.sinha at intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH 2/5] KabylakeSiliconPkg: Casting
> functions to EFIAPI
>
> From: Prince Agyeman <prince.agyeman at intel.com>
>
> This fixes the calling convension issues in gcc
>
> Gcc build was tested on Ubuntu 16.04.5 LTS with gcc version 5.4.0, nasm version
> 2.11.08
>
> Cc: Michael Kubacki <michael.a.kubacki at intel.com>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> Cc: Liming Gao <liming.gao at intel.com>
> Cc: Ankit Sinha <ankit.sinha at intel.com>
>
> Signed-off-by: Prince Agyeman <prince.agyeman at intel.com>
> ---
> .../Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h | 11 +++--------
> .../Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c | 11
> +++--------
> .../KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h | 12
> ++++--------
> .../KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore.c | 12
> ++++--------
> 4 files changed, 14 insertions(+), 32 deletions(-)
>
> diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h
> index 58ef567..666340e 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h
> +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h
> @@ -1,14 +1,8 @@
> /** @file
> Header file for PCH Init SMM Handler
>
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> -This program
> and the accompanying materials are licensed and made available under -the
> terms and conditions of the BSD License that accompanies this distribution.
> -The full text of the license may be found at
> -http://opensource.org/licenses/bsd-license.php.
> -
> -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS
> OR IMPLIED.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
>
> @@ -211,6 +205,7 @@ PchPcieLinkEqHandlerFunction (
>
> **/
> VOID
> +EFIAPI
> PchPcieIoTrapSmiCallback (
> IN EFI_HANDLE DispatchHandle,
> IN EFI_SMM_IO_TRAP_CONTEXT *CallbackContext,
> diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c
> index b4234f6..847fbfb 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c
> +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c
> @@ -1,14 +1,8 @@
> /** @file
> PCH Pcie SMM Driver Entry
>
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> -This program
> and the accompanying materials are licensed and made available under -the
> terms and conditions of the BSD License that accompanies this distribution.
> -The full text of the license may be found at
> -http://opensource.org/licenses/bsd-license.php.
> -
> -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS
> OR IMPLIED.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> #include "PchInitSmm.h"
> @@ -244,6 +238,7 @@ PchPciePmIoTrapSmiCallback (
>
> **/
> VOID
> +EFIAPI
> PchPcieIoTrapSmiCallback (
> IN EFI_HANDLE DispatchHandle,
> IN EFI_SMM_IO_TRAP_CONTEXT *CallbackContext,
> diff --git
> a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h
> index 3eebdc1..a9f0664 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h
> +++
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h
> @@ -1,14 +1,8 @@
> /** @file
> Prototypes and defines for the PCH SMM Dispatcher.
>
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> -This program
> and the accompanying materials are licensed and made available under -the
> terms and conditions of the BSD License that accompanies this distribution.
> -The full text of the license may be found at
> -http://opensource.org/licenses/bsd-license.php.
> -
> -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS
> OR IMPLIED.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> #ifndef PCH_SMM_H
> @@ -516,6 +510,7 @@ typedef struct {
> registered and the SMI source has been enabled.
> **/
> EFI_STATUS
> +EFIAPI
> PchSmmCoreRegister (
> IN PCH_SMM_GENERIC_PROTOCOL *This,
> IN EFI_SMM_HANDLER_ENTRY_POINT2 DispatchFunction,
> @@ -536,6 +531,7 @@ PchSmmCoreRegister (
> @retval EFI_INVALID_PARAMETER Handle is invalid.
> **/
> EFI_STATUS
> +EFIAPI
> PchSmmCoreUnRegister (
> IN PCH_SMM_GENERIC_PROTOCOL *This,
> IN EFI_HANDLE *DispatchHandle
> diff --git
> a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore.
> c
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore.
> c
> index 77f0561..cb3bfba 100644
> ---
> a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore.
> c
> +++
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCo
> +++ re.c
> @@ -2,14 +2,8 @@
> This driver is responsible for the registration of child drivers
> and the abstraction of the PCH SMI sources.
>
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> -This program
> and the accompanying materials are licensed and made available under -the
> terms and conditions of the BSD License that accompanies this distribution.
> -The full text of the license may be found at
> -http://opensource.org/licenses/bsd-license.php.
> -
> -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS
> OR IMPLIED.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> #include "PchSmm.h"
> @@ -331,6 +325,7 @@ SmiInputValueDuplicateCheck (
> registered and the SMI source has been enabled.
> **/
> EFI_STATUS
> +EFIAPI
> PchSmmCoreRegister (
> IN PCH_SMM_GENERIC_PROTOCOL *This,
> IN EFI_SMM_HANDLER_ENTRY_POINT2 DispatchFunction,
> @@ -602,6 +597,7 @@ Error:
> @retval EFI_INVALID_PARAMETER Handle is invalid.
> **/
> EFI_STATUS
> +EFIAPI
> PchSmmCoreUnRegister (
> IN PCH_SMM_GENERIC_PROTOCOL *This,
> IN EFI_HANDLE *DispatchHandle
> --
> 2.7.4
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#41099): https://edk2.groups.io/g/devel/message/41099
Mute This Topic: https://groups.io/mt/31632304/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list