[edk2-devel] [PATCH 0/6] Fix race condition and add event protocol
Laszlo Ersek
lersek at redhat.com
Fri May 24 09:43:39 UTC 2019
On 05/24/19 07:04, Gao, Zhichao wrote:
> There is a race condition in CoreWaitForEvent function:
> If an interrupt happens between CheckEvent and gIdleLoopEvent,
> there would be a event pending during cpu sleep.
> So it is required to check the gEventPending with the interrupt
> disabled.
> Implement a gEfiCpu2ProtocolGuid to fix that. The protocol include
> one interface to enable interrupt and put the cpu to sleep.
>
> Add a event protocol gEdkiiCommonEventProtocolGuid to support
> all TPL event. It is require for PI drivers that use HW interrput.
>
> Cc: Jian J Wang <jian.j.wang at intel.com>
> Cc: Hao A Wu <hao.a.wu at intel.com>
> cc: Ray Ni <ray.ni at intel.com>
> Cc: Star Zeng <star.zeng at intel.com>
> Cc: Liming gao <liming.gao at intel.com>
> Cc: Sean Brogan <sean.brogan at microsoft.com>
> Cc: Michael Turner <Michael.Turner at microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew at microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Eric Dong <eric.dong at intel.com>
> Cc: Laszlo Ersek <lersek at redhat.com>
Thanks for the CC; I'll let others review this series.
Thanks
Laszlo
> Sean Brogan (5):
> MdeModulePkg: Add gEdkiiCommonEventProtocolGuid for event
> MdePkg/BaseLib.h: Add EnableInterruptsAndSleep function declare
> MdePkg/BaseLib: Implement EnableInterruptsAndSleep
> MdePkg: Add gEfiCpu2ProtocolGuid and header file
> MdeModulePkg/DxeMain: Implement common event protocol
>
> Zhichao Gao (1):
> UefiCpuPkg/CpuDxe: Implement Cpu2 protocol
>
> MdeModulePkg/Core/Dxe/DxeMain.h | 64 ++++++++++-
> MdeModulePkg/Core/Dxe/DxeMain.inf | 1 +
> MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 22 ++++
> .../Core/Dxe/DxeMain/DxeProtocolNotify.c | 1 +
> MdeModulePkg/Core/Dxe/Event/Event.c | 102 ++++++++++++++++--
> MdeModulePkg/Core/Dxe/Event/Event.h | 2 +-
> MdeModulePkg/Include/Protocol/CommonEvent.h | 18 ++++
> MdeModulePkg/MdeModulePkg.dec | 3 +
> MdePkg/Include/Library/BaseLib.h | 11 ++
> MdePkg/Include/Protocol/Cpu2.h | 43 ++++++++
> .../Library/BaseLib/Ia32/EnableInterrupts.c | 18 +++-
> .../BaseLib/Ia32/EnableInterrupts.nasm | 15 ++-
> .../Library/BaseLib/X64/EnableInterrupts.nasm | 15 ++-
> MdePkg/MdePkg.dec | 3 +
> UefiCpuPkg/CpuDxe/CpuDxe.c | 40 ++++++-
> UefiCpuPkg/CpuDxe/CpuDxe.h | 15 +++
> UefiCpuPkg/CpuDxe/CpuDxe.inf | 3 +-
> 17 files changed, 358 insertions(+), 18 deletions(-)
> create mode 100644 MdeModulePkg/Include/Protocol/CommonEvent.h
> create mode 100644 MdePkg/Include/Protocol/Cpu2.h
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#41326): https://edk2.groups.io/g/devel/message/41326
Mute This Topic: https://groups.io/mt/31741727/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list