[edk2-devel] [edk2] [RFC PATCH] OptionRomPkg: import MarvelYukonDxe driver

[Alan Ott]

On 5/23/19 12:36 PM, Ard Biesheuvel wrote:
> (cc the correct list)
>
> On Thu, 23 May 2019 at 17:24, Leif Lindholm <leif.lindholm at linaro.org> wrote:
>> On Tue, May 21, 2019 at 02:38:47PM +0100, Ard Biesheuvel wrote:
>>> (+ Robin)
>>>
>>> On Wed, 19 Apr 2017 at 15:25, Leif Lindholm <leif.lindholm at linaro.org> wrote:
>>>> The Marvell Yukon Ethernet controller driver has existed in
>>>> OpenPlatformPkg for a while now. The chip exists on plug-in cards,
>>>> as well as (at least) the ARM Juno development board and the
>>>> Softiron 1000 platform.
>>>>
>>>> Buildable as a standalone driver, also as EBC.
>>>>
>>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>>> Signed-off-by: Leif Lindholm <leif.lindholm at linaro.org>
>>> Given that all of OptionRomPkg has been moved out of edk2 now, can we
>>> resurrect this driver in edk2-platforms/Silicon/Marvell perhaps?
>> Yes. The only thing holding it back was me wishing to either improve
>> on its coding style conformance or at least separate the imported bits
>> from the UEFI glue. The history of that driver isn't great.
>>
>> At the same time, as you commented on the DwEmax driver, separation
>> between MAC and PHY would be a nice thing to have, and that driver
>> also doesn't.
>>
> Yes, but since no generic abstraction exists today, this is going to
> be a longer term effort anyway, and so it shouldn't block
> reintroduction of this driver.
>
>> Then again, the driver is fairly well tested and seems to work OK, so
>> if someone was to resubmit the final version from
>> https://git.linaro.org/uefi/OpenPlatformPkg.git, reworked for
>> edk2-platforms, I might just go along with it.
>>
> OK, so taking the existing code and making it build in edk2-platforms
> is not going to be a huge amount of work, and I'm happy to look into
> that, provided that there is a point to doing so.
>
> Robin brought this up so I assume he has an interest in this.
>
> Thomas, Alan, could you comment as well, please?

It sounds good to me. The driver worked for us on OverDrive 1000 and 
iirc worked for others on Juno.

Alan.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41343): https://edk2.groups.io/g/devel/message/41343
Mute This Topic: https://groups.io/mt/31733023/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-