[edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules

[Laszlo Ersek]

On 05/27/19 18:56, Laszlo Ersek wrote:
> On 05/27/19 08:36, Wu, Hao A wrote:
>> '''
>> Please note that this patch will be hold until all the below requirements
>> are met:
>>
>> A. edk2-stable201905 is created;
>> B. OvmfPkg has drop its usage of the legacy ISA stack (which includes
>>    the IsaAcpiDxe driver);
>> C. UefiPayloadPkg has been updated to drop its consume to the
>>    8259InterruptControllerDxe driver.
>> '''
>>
>> This patch itself will not be sent to the mailing list and is only
>> available at:
>> https://github.com/hwu25/edk2/tree/delete_framework
>> (https://github.com/hwu25/edk2/commit/84e58f89f6d03f9cc3399cced9d5d5529e06a416)
>>
>>
>> Below modules will be removed from PcAtChipsetPkg:
>> * PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
>> * PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
>> * PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
>>
>> They are considered legacy framework components and will no longer be used
>> after the removal of IntelFramework[Module]Pkg.
>>
>> Also, the unused (after the modules being removed) PCDs will be deleted in
>> package level DEC/UNI files.
> 
> Please include a reference to
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1844> in the commit message.

Sorry, I missed that the patch was not sent to the list -- but I've now
checked in your personal repo, and the BZ reference is already there in
the commit message.

Thanks
Laszlo

> 
> (I might comment more later; not sure just yet.)
> 
> Thanks
> Laszlo
> 
>>
>> Cc: Ray Ni <ray.ni at intel.com>
>> Cc: Andrew Fish <afish at apple.com>
>> Cc: Laszlo Ersek <lersek at redhat.com>
>> Cc: Leif Lindholm <leif.lindholm at linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney at intel.com>
>>
>>
>> Hao A Wu (1):
>>   PcAtChipsetPkg: Remove framework modules
>>
>>  PcAtChipsetPkg/PcAtChipsetPkg.dec                             |  58 --
>>  PcAtChipsetPkg/PcAtChipsetPkg.dsc                             |   5 +-
>>  PcAtChipsetPkg/8254TimerDxe/8254Timer.inf                     |  42 --
>>  PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf            |  46 --
>>  PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf                         |  50 --
>>  PcAtChipsetPkg/8254TimerDxe/Timer.h                           | 185 ------
>>  PcAtChipsetPkg/8259InterruptControllerDxe/8259.h              | 220 -------
>>  PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h                       | 269 ---------
>>  PcAtChipsetPkg/8254TimerDxe/Timer.c                           | 401 -------------
>>  PcAtChipsetPkg/8259InterruptControllerDxe/8259.c              | 622 --------------------
>>  PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c                     | 301 ----------
>>  PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c                           | 353 -----------
>>  PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c                       | 386 ------------
>>  PcAtChipsetPkg/8254TimerDxe/Timer.uni                         |  16 -
>>  PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni                    |  14 -
>>  PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni      |  16 -
>>  PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni |  14 -
>>  PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni                         |  16 -
>>  PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni                    |  14 -
>>  PcAtChipsetPkg/PcAtChipsetPkg.uni                             |  52 +-
>>  20 files changed, 2 insertions(+), 3078 deletions(-)
>>  delete mode 100644 PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
>>  delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
>>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
>>  delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.h
>>  delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.h
>>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h
>>  delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.c
>>  delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.c
>>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c
>>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c
>>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c
>>  delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.uni
>>  delete mode 100644 PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni
>>  delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni
>>  delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni
>>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni
>>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni
>>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41422): https://edk2.groups.io/g/devel/message/41422
Mute This Topic: https://groups.io/mt/31806937/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-