[edk2-devel] [Patch 0/3] Add modules to BoardModulePkg.

[Liming Gao]

Besides, please submit BZ for the change. 

>-----Original Message-----
>From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Tuesday, May 28, 2019 8:39 AM
>To: devel at edk2.groups.io; Dong, Eric <eric.dong at intel.com>
>Subject: Re: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg.
>
>Eric:
>  I have two comments.
>1. Add BoardModulePkg.dsc to cover the build for new added modules.
>2. Remove BIOS_ID_GUID macro definition in Guid/BiosId.h. There is no code
>to consume it.
>
>Thanks
>Liming
>>-----Original Message-----
>>From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
>>Dong, Eric
>>Sent: Monday, May 27, 2019 9:13 AM
>>To: devel at edk2.groups.io
>>Subject: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg.
>>
>>Add new package BoardModulePkg in Platform/Intel folder. This folder
>>used to keep the board generic modules, such as Cmos, BiosId.
>>
>>Add Cmos and BiosId related modules to BoardModulePkg.
>>
>>
>>Eric Dong (3):
>>  Maintainers.txt: Add BoardModulePkg in Platform/Intel/ folder.
>>  Platform/Intel: Add Cmos related modules to BoardModulePkg
>>  Platform/Intel/BoardModulePkg: Add BiosId Module.
>>
>> Maintainers.txt                               |   4 +
>> .../Intel/BoardModulePkg/BoardModulePkg.dec   |  38 ++
>> .../BoardModulePkg/Include/Guid/BiosId.h      |  59 +++
>> .../Include/Library/BiosIdLib.h               |  57 ++
>> .../Include/Library/CmosAccessLib.h           | 106 ++++
>> .../Include/Library/PlatformCmosAccessLib.h   |  68 +++
>> .../Library/BiosIdLib/DxeBiosIdLib.c          | 175 +++++++
>> .../Library/BiosIdLib/DxeBiosIdLib.inf        |  42 ++
>> .../Library/BiosIdLib/PeiBiosIdLib.c          | 191 +++++++
>> .../Library/BiosIdLib/PeiBiosIdLib.inf        |  42 ++
>> .../Library/CmosAccessLib/CmosAccessLib.c     | 486 ++++++++++++++++++
>> .../Library/CmosAccessLib/CmosAccessLib.inf   |  28 +
>> .../CmosAccessLib/CmosAccessLibInternal.h     |  35 ++
>> .../PlatformCmosAccessLibNull.c               |  39 ++
>> .../PlatformCmosAccessLibNull.inf             |  23 +
>> 15 files changed, 1393 insertions(+)
>> create mode 100644 Platform/Intel/BoardModulePkg/BoardModulePkg.dec
>> create mode 100644
>Platform/Intel/BoardModulePkg/Include/Guid/BiosId.h
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Include/Library/BiosIdLib.h
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Include/Library/CmosAccessLib.h
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Include/Library/PlatformCmosAccessLib.h
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.c
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.inf
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.c
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.inf
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.c
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLibInte
>r
>>nal.h
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platfor
>>mCmosAccessLibNull.c
>> create mode 100644
>>Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platfor
>>mCmosAccessLibNull.inf
>>
>>--
>>2.21.0.windows.1
>>
>>
>>
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41436): https://edk2.groups.io/g/devel/message/41436
Mute This Topic: https://groups.io/mt/31804579/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-