[edk2-devel] [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library

[Leif Lindholm]

On Fri, May 31, 2019 at 03:22:25PM +0200, Ard Biesheuvel wrote:
> > > +  GCC:*_*_*_CC_FLAGS = -fno-lto -ffreestanding -Wno-unused-label
> >
> > Hmm. You add -ffreestanding here, but you also add it to the CLANG
> > profiles in 4/7. Could we do one of:
> > - dropping this one, adding -ffreestanding to GCC profiles too in 4/7
> > - keeping this one, dropping the -ffreestanding from 4/7?
> >
> 
> In my opinion, we should be using -ffreestanding for all GCC family
> toolchains for all architectures.

I agree. Could you update 4/7 to do that, and add RVCT droppage to
commit message for this one?

If so, for series:
Reviewed-by: Leif Lindholm <leif.lindholm at linaro.org>

/
    Leif

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41746): https://edk2.groups.io/g/devel/message/41746
Mute This Topic: https://groups.io/mt/31879989/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-