Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h

[Rebecca Cran]

Liming,


Yes lots of platforms use the structures, but most (all?) don't 
reference the fields themselves.

For example, searching for "FirwareVersion" in edk2-platforms gives just 
one results:


../edk2-platforms/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c:576: 
0,                    // FirwareVersion


Same for 'Processor64BitCapble:


../edk2-platforms/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c:276: 
// Processor64BitCapble            :1;


I did find a problem with this patch: SmbiosView in edk2 needs updated 
at the same time - so I'll send out a v2 shortly.


-- 

Rebecca Cran


On 12/2/20 6:18 PM, gaoliming wrote:
> Rebecca:
>    I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms.
> There are many platform SmbiosDxe driver to depend on them.
>    So, this change impacts widely. This change is just to rename field name.
> There is no real functionality change. I suggest to add comments for those
> typo fields instead of changing them.
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: bounce+27952+68193+4905953+8761045 at groups.io
>> <bounce+27952+68193+4905953+8761045 at groups.io> 代表 Rebecca Cran
>> 发送时间: 2020年12月3日 3:03
>> 收件人: devel at edk2.groups.io
>> 抄送: Rebecca Cran <rebecca at nuviainc.com>; Michael D Kinney
>> <michael.d.kinney at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>;
>> Zhiguang Liu <zhiguang.liu at intel.com>
>> 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
>>
>> Since the edk2-stable202011 tag has been created, I'm resubmitting the
>> SmBios.h typo fixes.
>>
>> Rebecca Cran (3):
>>    MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
>> struct
>>    MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
>>      ProcessorManufacturer
>>    MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
>> FirmwareVersion
>>
>>   MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
>>   1 file changed, 13 insertions(+), 13 deletions(-)
>>
>> --
>> 2.26.2
>>
>>
>>
>>
>>
>
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68205): https://edk2.groups.io/g/devel/message/68205
Mute This Topic: https://groups.io/mt/78675566/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-