回复: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h

[gaoliming]

Leif:
  I don't mean to object the incompatible change. I understand that the field name is changed for the readable source code. So, I propose to add comments for it to achieve the same goal.

Thanks
Liming
> -----邮件原件-----
> 发件人: Leif Lindholm <leif at nuviainc.com>
> 发送时间: 2020年12月3日 19:24
> 收件人: devel at edk2.groups.io; gaoliming at byosoft.com.cn
> 抄送: rebecca at nuviainc.com; 'Michael D Kinney'
> <michael.d.kinney at intel.com>; 'Zhiguang Liu' <zhiguang.liu at intel.com>;
> 'Laszlo Ersek' <lersek at redhat.com>
> 主题: Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
> 
> Liming,
> 
> These aren't randomly named fields, they are incorrect representations
> of an industry standard.
> 
> We are now in the period just after stable tag, breaking platforms is
> perfectly acceptable.
> 
> Also, we just happily broke all known platforms during soft freeze by
> merging the VariablePolicy set.
> 
> /
>     Leif
> 
> On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote:
> > Rebecca:
> >   I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in
> edk2-platforms.
> > There are many platform SmbiosDxe driver to depend on them.
> >   So, this change impacts widely. This change is just to rename field name.
> > There is no real functionality change. I suggest to add comments for those
> > typo fields instead of changing them.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: bounce+27952+68193+4905953+8761045 at groups.io
> > > <bounce+27952+68193+4905953+8761045 at groups.io> 代表 Rebecca
> Cran
> > > 发送时间: 2020年12月3日 3:03
> > > 收件人: devel at edk2.groups.io
> > > 抄送: Rebecca Cran <rebecca at nuviainc.com>; Michael D Kinney
> > > <michael.d.kinney at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>;
> > > Zhiguang Liu <zhiguang.liu at intel.com>
> > > 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
> > >
> > > Since the edk2-stable202011 tag has been created, I'm resubmitting the
> > > SmBios.h typo fixes.
> > >
> > > Rebecca Cran (3):
> > >   MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> > > struct
> > >   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
> > >     ProcessorManufacturer
> > >   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
> > > FirmwareVersion
> > >
> > >  MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
> > >  1 file changed, 13 insertions(+), 13 deletions(-)
> > >
> > > --
> > > 2.26.2
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> > 
> >
> >




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68306): https://edk2.groups.io/g/devel/message/68306
Mute This Topic: https://groups.io/mt/78700310/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-