[edk2-devel] [PATCH v3 3/3] ArmPkg: add Universal/Smbios as a generic SMBIOS library

Leif Lindholm leif at nuviainc.com
Mon Dec 7 17:11:21 UTC 2020


On Sun, Dec 06, 2020 at 21:59:48 -0700, Rebecca Cran wrote:
> On 11/19/20 5:58 AM, Leif Lindholm wrote:
> 
> > > +#define MAX_HANDLE_COUNT  0x10
> > Why?
> > Does this belong in a generic header?
>
> It's an arbitrary value, since the SMBIOS protocol doesn't have a way of
> letting you know how many records of a certain type are available without
> iterating through them. It might be better to just iterate twice.

Sadly, yes.
Avoiding hard-coding of sizes is worth some extra code.

/
    Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68384): https://edk2.groups.io/g/devel/message/68384
Mute This Topic: https://groups.io/mt/78172736/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list