[edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs

[Ard Biesheuvel]

On 12/7/20 7:31 PM, Samer El-Haj-Mahmoud wrote:
> Any update on getting this merged?
> 
>  

Pushed as c3c477792d2f..100e360ab522 (with the doc URL folded into the
commit message)

> 
> *From:* devel at edk2.groups.io <devel at edk2.groups.io> *On Behalf Of *Samer
> El-Haj-Mahmoud via groups.io
> *Sent:* Sunday, November 22, 2020 9:49 AM
> *To:* devel at edk2.groups.io; Andrei Warkentin (awarkentin at vmware.com)
> <awarkentin at vmware.com>; Andrei Warkentin <andrey.warkentin at gmail.com>;
> leif at nuviainc.com
> *Cc:* Ard Biesheuvel <Ard.Biesheuvel at arm.com>; pete at akeo.ie;
> philmd at redhat.com; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>
> *Subject:* Re: [edk2-devel] [edk2-platforms][PATCH 1/1]
> Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs
> 
>  
> 
> Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com
> <mailto:Samer.El-Haj-Mahmoud at arm.com>>
> 
>  
> 
> *From:* devel at edk2.groups.io <mailto:devel at edk2.groups.io>
> <devel at edk2.groups.io <mailto:devel at edk2.groups.io>> *On Behalf Of
> *Andrei Warkentin via groups.io
> *Sent:* Wednesday, November 18, 2020 6:21 PM
> *To:* Andrei Warkentin <andrey.warkentin at gmail.com
> <mailto:andrey.warkentin at gmail.com>>; devel at edk2.groups.io
> <mailto:devel at edk2.groups.io>; leif at nuviainc.com <mailto:leif at nuviainc.com>
> *Cc:* Ard Biesheuvel <Ard.Biesheuvel at arm.com
> <mailto:Ard.Biesheuvel at arm.com>>; pete at akeo.ie <mailto:pete at akeo.ie>;
> philmd at redhat.com <mailto:philmd at redhat.com>
> *Subject:* Re: [edk2-devel] [edk2-platforms][PATCH 1/1]
> Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs
> 
>  
> 
> Hi Leif,
> 
>  
> 
> I got these
> from https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md
> 
>  
> 
> A
> 
> ------------------------------------------------------------------------
> 
> *From:*devel at edk2.groups.io <mailto:devel at edk2.groups.io>
> <devel at edk2.groups.io <mailto:devel at edk2.groups.io>> on behalf of Leif
> Lindholm via groups.io <leif=nuviainc.com at groups.io
> <mailto:leif=nuviainc.com at groups.io>>
> *Sent:* Tuesday, November 17, 2020 10:02 AM
> *To:* Andrei Warkentin <andrey.warkentin at gmail.com
> <mailto:andrey.warkentin at gmail.com>>
> *Cc:* devel at edk2.groups.io <mailto:devel at edk2.groups.io>
> <devel at edk2.groups.io <mailto:devel at edk2.groups.io>>;
> ard.biesheuvel at arm.com <mailto:ard.biesheuvel at arm.com>
> <ard.biesheuvel at arm.com <mailto:ard.biesheuvel at arm.com>>; pete at akeo.ie
> <mailto:pete at akeo.ie> <pete at akeo.ie <mailto:pete at akeo.ie>>;
> philmd at redhat.com <mailto:philmd at redhat.com> <philmd at redhat.com
> <mailto:philmd at redhat.com>>
> *Subject:* Re: [edk2-devel] [edk2-platforms][PATCH 1/1]
> Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs
> 
>  
> 
> Hi Andrei,
> 
> On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote:
>> Like the Pi 4B, the 3GB/4GB choices apply to it as well.
>>
>> Signed-off-by: Andrei Warkentin <andrey.warkentin at gmail.com
> <mailto:andrey.warkentin at gmail.com>>
> 
> Patch looks straghtforward enough, but ideally I'd like someone to
> chime in with tested-by. That hasn't happened so far - are these
> documented anywhere I could easily sanity check myself?
> 
> /
>     Leif
> 
>> ---
>>  Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git
> a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
>> index 5302ccd8..ade91c9f 100644
>> --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
>> +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
>> @@ -596,6 +596,10 @@ RpiFirmwareGetModelName (
>>      return "Raspberry Pi Compute Module 3+";
>>    case 0x11:
>>      return "Raspberry Pi 4 Model B";
>> +  case 0x13:
>> +    return "Raspberry Pi 400";
>> +  case 0x14:
>> +    return "Raspberry Pi Compute Module 4";
>>    default:
>>      return "Unknown Raspberry Pi Model";
>>    }
>> @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily (
>>        *ModelFamily = 3;
>>        break;
>>    case 0x11:          // Raspberry Pi 4 Model B
>> +  case 0x13:          // Raspberry Pi 400
>> +  case 0x14:          // Raspberry Pi Computer Module 4
>>        *ModelFamily = 4;
>>        break;
>>    default:
>> --
>> 2.20.1
>>
> 
> 
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy
> the information in any medium. Thank you.
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68453): https://edk2.groups.io/g/devel/message/68453
Mute This Topic: https://groups.io/mt/78267546/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-