[edk2-devel] [PATCH v1 1/1] ShellPkg: Validate that the Boot CPU is present in MADT

[Joey Gouly]

> > +/**
> > +  This function validates that the GICC structure contains an entry for
> > +  the Boot CPU.
> > +
> > +  @param [in] Ptr     Pointer to the start of the field data.
> > +  @param [in] Context Pointer to context specific information e.g. this
> > +                      could be a pointer to the ACPI table header.
> > +**/
> > +STATIC
> > +VOID
> > +EFIAPI
> > +ValidateBootMpidr (
> > +  IN UINT8* Ptr,
> > +  IN VOID*  Context
> > +  )
> > +{
> > +#if defined(MDE_CPU_ARM) || defined(MDE_CPU_AARCH64)
>
> Surely all of the struct that should be called mGicCParser is only for
> ARM/AARCH64 and could be moved into a source file just included for
> those, and this function with it?
>
> With the only filtering on architectures done in ParseAcpiMadt?

I think that could be done if/when another architecture wants to add some
specific support to this file. Otherwise, in my opinion it just adds more
files / layers without any real benefit.

Thanks for the other comments, I have fixed them, and will wait for your reply
to the above comment.

Joey

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68477): https://edk2.groups.io/g/devel/message/68477
Mute This Topic: https://groups.io/mt/78636882/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-