[edk2-devel] [PATCH v2 1/1] IntelSiliconPkg/ShadowMicrocodePei: Fix return value in ShadowMicrocode.
Ni, Ray
ray.ni at intel.com
Wed Dec 9 12:58:27 UTC 2020
Reviewed-by: Ray Ni <ray.ni at intel.com>
> -----Original Message-----
> From: Li, Aaron <aaron.li at intel.com>
> Sent: Wednesday, December 9, 2020 3:00 PM
> To: devel at edk2.groups.io
> Cc: Ni, Ray <ray.ni at intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty at intel.com>; Fu, Siyuan <siyuan.fu at intel.com>
> Subject: [PATCH v2 1/1] IntelSiliconPkg/ShadowMicrocodePei: Fix return value in ShadowMicrocode.
>
> ShadowMicrocode should return EFI_NOT_FOUND when no valid Microcode found
> in FIT table.
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3110
>
> Signed-off-by: Aaron Li <aaron.li at intel.com>
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty at intel.com>
> Cc: Siyuan Fu <siyuan.fu at intel.com>
> ---
> Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei.c
> b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei.c
> index 5c7ee6910c8e..1494397a8e36 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei.c
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei.c
> @@ -377,6 +377,9 @@ IsValidFitTable (
> with microcode patches data in it.
>
>
>
> @retval EFI_SUCCESS The microcode has been shadowed to memory.
>
> + @retval EFI_INVALID_PARAMETER BufferSize or Buffer is NULL.
>
> + @retval EFI_INVALID_PARAMETER CpuIdCount not equal to 0 and MicrocodeCpuId is NULL.
>
> + @retval EFI_NOT_FOUND No valid microcode found.
>
> @retval EFI_OUT_OF_RESOURCES The operation fails due to lack of resources.
>
>
>
> **/
>
> @@ -390,6 +393,7 @@ ShadowMicrocode (
> OUT VOID **Buffer
>
> )
>
> {
>
> + EFI_STATUS Status;
>
> UINT64 FitPointer;
>
> FIRMWARE_INTERFACE_TABLE_ENTRY *FitEntry;
>
> UINT32 EntryNum;
>
> @@ -460,10 +464,13 @@ ShadowMicrocode (
> ));
>
>
>
> ShadowMicrocodePatchWorker (PatchInfoBuffer, PatchCount, TotalLoadSize, BufferSize, Buffer);
>
> + Status = EFI_SUCCESS;
>
> + } else {
>
> + Status = EFI_NOT_FOUND;
>
> }
>
>
>
> FreePool (PatchInfoBuffer);
>
> - return EFI_SUCCESS;
>
> + return Status;
>
> }
>
>
>
>
>
> --
> 2.29.2.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68548): https://edk2.groups.io/g/devel/message/68548
Mute This Topic: https://groups.io/mt/78824067/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list