[edk2-devel] [PATCH v1 00/16] Fix Ecc reported errors in ArmPlatformPkg

Ard Biesheuvel ard.biesheuvel at arm.com
Wed Dec 9 15:33:05 UTC 2020


On 12/3/20 7:19 PM, Pierre.Gondois at arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois at arm.com>
> 
> The Ecc tools available in the BaseTools package checks for
> good practice coding standards. Some errors reported while
> running Ecc on edk2/ArmPlatformPkg require modifications.
> 
> This patch set has a dependency over a similar patch set
> named "Fix Ecc reported errors from ArmPlatformPkg" for
> edk2-platforms and should not be merged independently.
> 
> The changes can be seen at: https://github.com/PierreARM/edk2/tree/1537_Ecc_ArmPlatformPkg_v1
> 
> Pierre Gondois (16):
>   ArmPlatformPkg: Fix Ecc error 3001 in NorFlashDxe
>   ArmPlatformPkg: Fix Ecc error 3002 in PL011UartLib
>   ArmPlatformPkg: Fix Ecc error 3002 in PL061GpioDxe
>   ArmPlatformPkg: Fix Ecc error 5007 in LcdGraphicsOutputDxe
>   ArmPlatformPkg: Fix Ecc error 5007 in NorFlashDxe
>   ArmPlatformPkg: Fix Ecc error 5007 in PL061GpioDxe
>   ArmPlatformPkg: Fix Ecc error 5007 in PL031RealTimeClockLib
>   ArmPlatformPkg: Fix Ecc error 10016 in PrePi
>   ArmPlatformPkg: Fix Ecc error 10016 in LcdPlatformNullLib
>   ArmPlatformPkg: Fix Ecc error 10014 in LcdGraphicsOutputDxe
>   ArmPlatformPkg: Fix Ecc error 10014 in PL061GpioDxe
>   ArmPlatformPkg: Fix Ecc error 10014 in SP805WatchdogDxe
>   ArmPlatformPkg: Fix Ecc error 10006 in ArmPlatformPkg.dsc
>   ArmPlatformPkg: Fix Ecc error 8001 in PrePi
>   ArmPlatformPkg: Fix Ecc error 8005
>   ArmPlatformPkg: Fix cspell reported spelling/wording
> 

Patches above

Reviewed-by: Ard Biesheuvel <ard.biesheuvel at arm.com>

Merged as #1207 into master.

>   ArmPlatformPkg: Fix Ecc error 8005

This one needs further discussion, and alignment with edk2-platforms
changes.


>  ArmPlatformPkg/ArmPlatformPkg.dsc             |  9 +-
>  .../LcdGraphicsOutputBlt.c                    | 98 ++++++++++---------
>  .../LcdGraphicsOutputDxe.c                    | 30 +++---
>  .../LcdGraphicsOutputDxe.h                    |  4 +-
>  .../LcdGraphicsOutputDxe.inf                  |  5 +-
>  .../Drivers/NorFlashDxe/NorFlashDxe.c         |  8 +-
>  .../Drivers/PL061GpioDxe/PL061Gpio.c          | 12 +--
>  .../Drivers/PL061GpioDxe/PL061GpioDxe.inf     |  3 +-
>  .../SP805WatchdogDxe/SP805WatchdogDxe.inf     |  3 +-
>  .../Include/Library/LcdPlatformLib.h          | 21 ++--
>  .../LcdPlatformNullLib/LcdPlatformNullLib.c   |  4 +-
>  .../LcdPlatformNullLib/LcdPlatformNullLib.inf |  3 +-
>  .../Library/PL011UartLib/PL011UartLib.c       | 12 +--
>  .../PL031RealTimeClockLib.c                   |  4 +-
>  ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c    |  4 +-
>  .../PrePi/AArch64/ModuleEntryPoint.S          |  4 +-
>  ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S   |  4 +-
>  ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm |  4 +-
>  ArmPlatformPkg/PrePi/PeiUniCore.inf           |  3 +-
>  ArmPlatformPkg/PrePi/PrePi.h                  |  4 +-
>  20 files changed, 126 insertions(+), 113 deletions(-)
> 
> --
> 2.17.1
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68552): https://edk2.groups.io/g/devel/message/68552
Mute This Topic: https://groups.io/mt/78690942/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list