[edk2-devel] [PATCH v2 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(1Ah).

[Ni, Ray]

> +#define CPUID_HYBRID_INFORMATION_SUB_LEAF                               0x00
1. At first, I thought there is no need for a definition of xxx_SUB_LEAF. Later when
I checked the SDM, I found it says, "Hybrid Information Enumeration Leaf (EAX = 1AH, ECX = 0)".
It seems that maybe ECX=1 will be introduced in future.

But with this macro name, it's hard to choose the name for ECX=1.
So, I suggest changing the macro name to 
+#define CPUID_HYBRID_INFORMATION_MAIN_LEAF                               0x00

> 
> +  sub-leaf #CPUID_HYBRID_INFORMATION_SUB_LEAF.
2. Change to _xxx_MAIN_LEAF

> 
> +    UINT32  CoreType:8;
> 
3. Please define macros for core types: Intel Atom, Intel Core.
+#define CPUID_CORE_TYPE_INTEL_ATOM 0x40
+#define CPUID_CORE_TYPE_INTEL_ATOM 0x20


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68611): https://edk2.groups.io/g/devel/message/68611
Mute This Topic: https://groups.io/mt/78797264/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-