[edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use AllocatePages() for InitOrder

[Ni, Ray]

Reviewed-by: Ray Ni <ray.ni at intel.com>

> -----Original Message-----
> From: Zeng, Star <star.zeng at intel.com>
> Sent: Wednesday, December 9, 2020 7:28 PM
> To: devel at edk2.groups.io
> Cc: Zeng, Star <star.zeng at intel.com>; Ni, Ray <ray.ni at intel.com>; Dong, Eric <eric.dong at intel.com>; Laszlo Ersek
> <lersek at redhat.com>
> Subject: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use AllocatePages() for InitOrder
> 
> The required buffer size for InitOrder will be 96K when NumberOfCpus=1024.
> sizeof (CPU_FEATURES_INIT_ORDER) = 96
> NumberOfCpus = 1024 = 1K
> sizeof (CPU_FEATURES_INIT_ORDER) * NumberOfCpus = 96K
> 
> AllocateZeroPool() will call to PeiServicesAllocatePool() which will use
> EFI_HOB_MEMORY_POOL to management memory pool.
> EFI_HOB_MEMORY_POOL.Header.HobLength is UINT16 type, so there is no way
> for AllocateZeroPool() to allocate > 64K memory.
> 
> So AllocateZeroPool() could not be used anymore for the case above or
> even bigger required buffer size.
> 
> This patch updates the code to use AllocatePages() instead of
> AllocateZeroPool() to allocate buffer for InitOrder.
> 
> Signed-off-by: Star Zeng <star.zeng at intel.com>
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Eric Dong <eric.dong at intel.com>
> Cc: Laszlo Ersek <lersek at redhat.com>
> ---
>  .../Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c     | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> index d4a576385f0f..ba052732a86c 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> @@ -126,8 +126,9 @@ CpuInitDataInitialize (
> 
>    GetNumberOfProcessor (&NumberOfCpus, &NumberOfEnabledProcessors);
> 
> -  CpuFeaturesData->InitOrder = AllocateZeroPool (sizeof (CPU_FEATURES_INIT_ORDER) * NumberOfCpus);
> +  CpuFeaturesData->InitOrder = AllocatePages (EFI_SIZE_TO_PAGES (sizeof (CPU_FEATURES_INIT_ORDER) *
> NumberOfCpus));
>    ASSERT (CpuFeaturesData->InitOrder != NULL);
> +  ZeroMem (CpuFeaturesData->InitOrder, sizeof (CPU_FEATURES_INIT_ORDER) * NumberOfCpus);
> 
>    //
>    // Collect CPU Features information
> --
> 2.21.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68709): https://edk2.groups.io/g/devel/message/68709
Mute This Topic: https://groups.io/mt/78826783/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-