回复: [edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort

[gaoliming]

Create PR https://github.com/tianocore/edk2/pull/1219

 

Thanks

Liming

发件人: bounce+27952+68612+4905953+8761045 at groups.io
<bounce+27952+68612+4905953+8761045 at groups.io> 代表 gaoliming
发送时间: 2020年12月10日 9:28
收件人: devel at edk2.groups.io; anbazhagan at hp.com
抄送: jian.j.wang at intel.com; hao.a.wu at intel.com
主题: 回复: [edk2-devel] MdeModulePkg: Fix SetMem parameter in
OnigurumaUefiPort

 

Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn <mailto:gaoliming at byosoft.
com.cn> >

 

发件人: bounce+27952+68609+4905953+8761045 at groups.io
<mailto:bounce+27952+68609+4905953+8761045 at groups.io>
<bounce+27952+68609+4905953+8761045 at groups.io
<mailto:bounce+27952+68609+4905953+8761045 at groups.io> > 代表 Anbazhagan,
Baraneedharan via groups.io
发送时间: 2020年12月10日 8:21
收件人: devel at edk2.groups.io <mailto:devel at edk2.groups.io> 
抄送: gaoliming at byosoft.com.cn <mailto:gaoliming at byosoft.com.cn> ;
jian.j.wang at intel.com <mailto:jian.j.wang at intel.com> ; hao.a.wu at intel.com
<mailto:hao.a.wu at intel.com> 
主题: [edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort

 

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3085

 

Coding error in converting memset call to SetMem - Length and Value

is not swapped on calling SetMem

 

Signed-off-by: Baraneedharan Anbazhagan <anbazhagan at hp.com
<mailto:anbazhagan at hp.com> >

---

MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

 

diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

index 2b2b0d420d..9aa7b0a68e 100644

--- a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

+++ b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

@@ -93,6 +93,6 @@ void* memcpy (void *dest, const void *src, unsigned int
count)

 

 void* memset (void *dest, char ch, unsigned int count)

{

-  return SetMem (dest, ch, count);

+  return SetMem (dest, count, ch);

}

 

-- 

2.29.2.windows.3

 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68753): https://edk2.groups.io/g/devel/message/68753
Mute This Topic: https://groups.io/mt/78942337/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20201214/080e1b44/attachment.htm>