[edk2-devel] [PATCH v1 20/25] ArmPkg: Fix Ecc error 5007 in ArmLib
PierreGondois
pierre.gondois at arm.com
Wed Dec 16 17:21:55 UTC 2020
From: Pierre Gondois <Pierre.Gondois at arm.com>
This patch fixes the following Ecc reported error:
There should be no initialization of a variable as
part of its declaration
Signed-off-by: Pierre Gondois <Pierre.Gondois at arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_Ecc_ArmPkg_v1
ArmPkg/Library/ArmLib/ArmLib.c | 20 +++++---------------
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/ArmPkg/Library/ArmLib/ArmLib.c b/ArmPkg/Library/ArmLib/ArmLib.c
index 3905d02c5e7e..c454ce5b99ad 100644
--- a/ArmPkg/Library/ArmLib/ArmLib.c
+++ b/ArmPkg/Library/ArmLib/ArmLib.c
@@ -1,7 +1,7 @@
/** @file
Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>
- Copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.<BR>
+ Copyright (c) 2011 - 2020, ARM Ltd. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -19,9 +19,7 @@ ArmSetAuxCrBit (
IN UINT32 Bits
)
{
- UINT32 val = ArmReadAuxCr();
- val |= Bits;
- ArmWriteAuxCr(val);
+ ArmWriteAuxCr(ArmReadAuxCr() | Bits);
}
VOID
@@ -30,9 +28,7 @@ ArmUnsetAuxCrBit (
IN UINT32 Bits
)
{
- UINT32 val = ArmReadAuxCr();
- val &= ~Bits;
- ArmWriteAuxCr(val);
+ ArmWriteAuxCr(ArmReadAuxCr() & ~Bits);
}
//
@@ -45,10 +41,7 @@ ArmSetCpuActlrBit (
IN UINTN Bits
)
{
- UINTN Value;
- Value = ArmReadCpuActlr ();
- Value |= Bits;
- ArmWriteCpuActlr (Value);
+ ArmWriteCpuActlr (ArmReadCpuActlr () | Bits);
}
VOID
@@ -57,10 +50,7 @@ ArmUnsetCpuActlrBit (
IN UINTN Bits
)
{
- UINTN Value;
- Value = ArmReadCpuActlr ();
- Value &= ~Bits;
- ArmWriteCpuActlr (Value);
+ ArmWriteCpuActlr (ArmReadCpuActlr () & ~Bits);
}
UINTN
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69003): https://edk2.groups.io/g/devel/message/69003
Mute This Topic: https://groups.io/mt/79006210/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list