[edk2-devel] [edk2-platform][PATCH v2 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY

[Gao, Zhichao]

Hi Ray,

Do you have other concerns about this change?

Thanks,
Zhichao

> -----Original Message-----
> From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>
> Sent: Friday, December 25, 2020 12:34 AM
> To: Gao, Zhichao <zhichao.gao at intel.com>; Pete Batard <pete at akeo.ie>;
> devel at edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang at intel.com>; Wu, Hao A <hao.a.wu at intel.com>; Ni,
> Ray <ray.ni at intel.com>; Ard Biesheuvel <Ard.Biesheuvel at arm.com>; Samer El-
> Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>; Laszlo Ersek
> <lersek at redhat.com>
> Subject: RE: [edk2-devel] [edk2-platform][PATCH v2 3/3]
> MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY
> 
> Thanks Zhichao and Pete
> 
> Now that this series ( https://edk2.groups.io/g/devel/message/69264 ) is
> reviewed, can we get it pushed please?
> 
> Many thanks,
> --Samer
> 
> > -----Original Message-----
> > From: Gao, Zhichao <zhichao.gao at intel.com>
> > Sent: Wednesday, December 23, 2020 8:12 PM
> > To: Pete Batard <pete at akeo.ie>; devel at edk2.groups.io; Samer El-Haj-
> > Mahmoud <Samer.El-Haj-Mahmoud at arm.com>
> > Cc: Wang, Jian J <jian.j.wang at intel.com>; Wu, Hao A
> > <hao.a.wu at intel.com>; Ni, Ray <ray.ni at intel.com>; Ard Biesheuvel
> > <Ard.Biesheuvel at arm.com>
> > Subject: RE: [edk2-devel] [edk2-platform][PATCH v2 3/3]
> > MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY
> >
> > Reviewed-by: Zhichao Gao <zhichao.gao at intel.com>
> >
> > Thanks,
> > Zhichao
> >
> > > -----Original Message-----
> > > From: Pete Batard <pete at akeo.ie>
> > > Sent: Thursday, December 24, 2020 12:35 AM
> > > To: devel at edk2.groups.io; samer.el-haj-mahmoud at arm.com
> > > Cc: Wang, Jian J <jian.j.wang at intel.com>; Wu, Hao A
> > > <hao.a.wu at intel.com>; Gao, Zhichao <zhichao.gao at intel.com>; Ni, Ray
> > > <ray.ni at intel.com>; Ard Biesheuvel <Ard.Biesheuvel at arm.com>
> > > Subject: Re: [edk2-devel] [edk2-platform][PATCH v2 3/3]
> > > MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY
> > >
> > > On 2020.12.20 13:53, Samer El-Haj-Mahmoud wrote:
> > > > ConSplitter is using EFI_LIGHTGRAY foreground color for ConOut and
> > > > EFI_MAGENTA for StdErr consoles. This is impacting the DebugLib
> > > > output on that same serial console (e.g. DebugLibSerialPort) after
> > > > gEfiStandardErrorDeviceGuid is installed on that port. The impact
> > > > also extends to Linux serial console output in OVMF because it
> > > > inherits the color setting from the firmware.
> > > >
> > > > This is inconsistent and annoying, with MAGENTA being barely
> > > > legible on a black background.
> > > >
> > > > Let's change StdErr default color to LIGHTGRAY for consistency and
> > > > readability. This results in the same color being used for all
> > > > consoles sharing the same serial port (ConOut, StdErr, DebugLib,
> > > > OS
> > console).
> > > > Platforms wishing to distinguish the colors of consoles can do so
> > > > in their own Platform BDS initialization.
> > > >
> > > > Cc: Jian J Wang <jian.j.wang at intel.com>
> > > > Cc: Hao A Wu <hao.a.wu at intel.com>
> > > > Cc: Zhichao Gao <zhichao.gao at intel.com>
> > > > Cc: Ray Ni <ray.ni at intel.com>
> > > > Cc: Ard Biesheuvel <Ard.Biesheuvel at arm.com>
> > > > Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-
> > Mahmoud at arm.com>
> > > > ---
> > > >   MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +-
> > > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git
> > > > a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> > > > b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> > > > index b090de288517..e8cd4ce120a0 100644
> > > > --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> > > > +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> > > > @@ -1476,7 +1476,7 @@ ConSplitterStdErrDriverBindingStart (
> > > >     // their MaxMode and QueryData should be the intersection of both.
> > > >
> > > >     //
> > > >
> > > >     Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL,
> > > > NULL);
> > > >
> > > > -  ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR
> > > > (EFI_MAGENTA, EFI_BLACK));
> > > >
> > > > +  ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR
> > > > + (EFI_LIGHTGRAY, EFI_BLACK));
> > > >
> > > >
> > > >
> > > >     return Status;
> > > >
> > > >   }
> > > >
> > >
> > > Reviewed-by: Pete Batard <pete at akeo.ie>
> > > Tested-by: Pete Batard <pete at akeo.ie> (On an RPi 4 platform where
> > > this was another annoyance)
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69459): https://edk2.groups.io/g/devel/message/69459
Mute This Topic: https://groups.io/mt/79103140/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-