[edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c

[Gao, Zhichao]

Reviewed-by: Zhichao Gao <zhichao.gao at intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of gaoliming
> Sent: Tuesday, November 3, 2020 9:00 AM
> To: devel at edk2.groups.io; zhuenze at byosoft.com.cn; Gao, Zhichao
> <zhichao.gao at intel.com>
> Cc: gaoliming at byosoft.com.cn
> Subject: 回复: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c
> 
> Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: bounce+27952+66594+4905953+8761045 at groups.io
> > <bounce+27952+66594+4905953+8761045 at groups.io> 代表 Enze Zhu
> > 发送时间: 2020年10月26日 16:40
> > 收件人: devel at edk2.groups.io
> > 主题: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2998
> >
> > In the function FileBufferCutLine(),set the CutLine pointer to NULL,
> > The function header specifies that the pointer is valid on a
> > successful or failed return code.
> >
> > Signed-off-by: Enze Zhu <zhuenze at byosoft.com.cn>
> > ---
> >  ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git
> > a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > index 5659ec9810..925d910ae2 100644
> > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > @@ -2767,6 +2767,8 @@ FileBufferCutLine (
> >    UINTN           Row;
> >    UINTN           Col;
> >
> > +  *CutLine      = NULL;
> > +
> >    if (FileBuffer.ReadOnly) {
> >      StatusBarSetStatusString (L"Read Only File Can Not Be Modified");
> >      return EFI_SUCCESS;
> > --
> > 2.27.0.windows.1
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66909): https://edk2.groups.io/g/devel/message/66909
Mute This Topic: https://groups.io/mt/78000434/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-