[edk2-devel] [PATCH v1 01/12] ArmPkg/IndustryStandard: Add barebones FF-A header

[Sami Mujawar]

Hi Sughosh,

Thank you for this patch.

Please see my response inline marked [SAMI].

Regards,

Sami Mujawar

-----Original Message-----
From: Sughosh Ganu <sughosh.ganu at linaro.org> 
Sent: 21 October 2020 12:32 PM
To: devel at edk2.groups.io
Cc: Ard Biesheuvel <Ard.Biesheuvel at arm.com>; Sami Mujawar <Sami.Mujawar at arm.com>; Jiewen Yao <jiewen.yao at intel.com>; Achin Gupta <Achin.Gupta at arm.com>
Subject: [PATCH v1 01/12] ArmPkg/IndustryStandard: Add barebones FF-A header

From: Achin Gupta <achin.gupta at arm.com>

This patch adds a rudimentary header file with defines for FF-A ABIs
that will be used as the transport between S-EL0 and the SPM

Signed-off-by: Achin Gupta <achin.gupta at arm.com>
---
 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
new file mode 100644
index 0000000000..a8914085de
--- /dev/null
+++ b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
@@ -0,0 +1,16 @@
+/** @file
[SAMI] Please add file description, see section 5.2.3.1 of EDKII coding standard specification (https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/52_spacing)
[/SAMI]
+*
+*  Copyright (c) 2020, ARM Limited. All rights reserved.
+*
+*  SPDX-License-Identifier: BSD-2-Clause-Patent
[SAMI] Add reference to the specification, see section 5.2.3.5 of EDKII coding standard specification.
[/SAMI]
+*
+**/
+
+#ifndef __ARM_FFA_SVC_H__
+#define __ARM_FFA_SVC_H__
[SAMI] Make include guard compliant with EDKII coding standard, see section 5.3.5 (https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/53_include_files)
[/SAMI]
+
+#define ARM_SVC_ID_FFA_VERSION_AARCH32                  0x84000063
+#define ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ_AARCH64      0xC400006F
+#define ARM_SVC_ID_FFA_MSG_SEND_DIRECT_RESP_AARCH64     0xC4000070
+
+#endif
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67032): https://edk2.groups.io/g/devel/message/67032
Mute This Topic: https://groups.io/mt/77703647/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-