[edk2-devel] [VFR support REST_STYLE PATCH v3 3/4] MdeModulePkg/Library: Revise HiiLib to support REST_STYLE
Abner Chang
abner.chang at hpe.com
Fri Nov 6 03:36:03 UTC 2020
Fixed in v4 patch set.
thanks
> -----Original Message-----
> From: gaoliming [mailto:gaoliming at byosoft.com.cn]
> Sent: Thursday, November 5, 2020 9:42 AM
> To: devel at edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang at hpe.com>
> Cc: 'Dandan Bi' <dandan.bi at intel.com>; 'Eric Dong' <eric.dong at intel.com>;
> 'Gao, Liming' <liming.gao at intel.com>
> Subject: 回复: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4]
> MdeModulePkg/Library: Revise HiiLib to support REST_STYLE
>
> This patch is to check REST_STYLE flag. I think the commit message may be
> check REST_STYLE flag.
>
> > -----邮件原件-----
> > 发件人: bounce+27952+66976+4905953+8761045 at groups.io
> > <bounce+27952+66976+4905953+8761045 at groups.io> 代表 Abner Chang
> > 发送时间: 2020年11月4日 16:21
> > 收件人: devel at edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang at hpe.com>
> > 抄送: 'Dandan Bi' <dandan.bi at intel.com>; 'Eric Dong'
> <eric.dong at intel.com>;
> > Gao, Liming <liming.gao at intel.com>
> > 主题: Re: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4]
> > MdeModulePkg/Library: Revise HiiLib to support REST_STYLE
> >
> > Sorry, forget to CC reviewers.
> >
> > Abner
> >
> > > -----Original Message-----
> > > From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf
> > > Of Abner Chang
> > > Sent: Wednesday, November 4, 2020 2:36 PM
> > > To: devel at edk2.groups.io
> > > Subject: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4]
> > > MdeModulePkg/Library: Revise HiiLib to support REST_STYLE
> > >
> > > Add REST_STYLE support
> > >
> > > Signed-off-by: Jiaxin Wu <jiaxin.wu at intel.com>
> > > Signed-off-by: Ting Ye <ting.ye at intel.com>
> > > Signed-off-by: Siyuan Fu <siyuan.fu at intel.com>
> > > Signed-off-by: Fan Wang <fan.wang at intel.com>
> > > Signed-off-by: Abner Chang <abner.chang at hpe.com>
> > > ---
> > > MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 14 +++++++-------
> > > 1 file changed, 7 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> > > b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> > > index 564169bc14..57602828fe 100644
> > > --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> > > +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> > > @@ -3605,7 +3605,7 @@ HiiCreateCheckBoxOpCode (
> > > EFI_IFR_CHECKBOX OpCode;
> > > UINTN Position;
> > >
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode));
> > > OpCode.Question.QuestionId = QuestionId;
> > > @@ -3674,7 +3674,7 @@ HiiCreateNumericOpCode (
> > > UINTN Position;
> > > UINTN Length;
> > >
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE))) == 0);
> > >
> > > Length = 0;
> > > ZeroMem (&OpCode, sizeof (OpCode)); @@ -3773,7 +3773,7 @@
> > > HiiCreateStringOpCode (
> > > EFI_IFR_STRING OpCode;
> > > UINTN Position;
> > >
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode));
> > > OpCode.Question.Header.Prompt = Prompt;
> > > @@ -3841,7 +3841,7 @@ HiiCreateOneOfOpCode (
> > > UINTN Length;
> > >
> > > ASSERT (OptionsOpCodeHandle != NULL);
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_OPTIONS_ONLY))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE | EFI_IFR_FLAG_OPTIONS_ONLY))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode));
> > > OpCode.Question.Header.Prompt = Prompt;
> > > @@ -3912,7 +3912,7 @@ HiiCreateOrderedListOpCode (
> > > UINTN Position;
> > >
> > > ASSERT (OptionsOpCodeHandle != NULL);
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_OPTIONS_ONLY))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE | EFI_IFR_FLAG_OPTIONS_ONLY))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode));
> > > OpCode.Question.Header.Prompt = Prompt;
> > > @@ -4009,7 +4009,7 @@ HiiCreateDateOpCode (
> > > EFI_IFR_DATE OpCode;
> > > UINTN Position;
> > >
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE))) == 0);
> > > ASSERT ((DateFlags & (~(EFI_QF_DATE_YEAR_SUPPRESS |
> > > EFI_QF_DATE_MONTH_SUPPRESS | EFI_QF_DATE_DAY_SUPPRESS |
> > > EFI_QF_DATE_STORAGE))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode)); @@ -4074,7 +4074,7 @@
> > > HiiCreateTimeOpCode (
> > > EFI_IFR_TIME OpCode;
> > > UINTN Position;
> > >
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE))) == 0);
> > > ASSERT ((TimeFlags & (~(QF_TIME_HOUR_SUPPRESS |
> > > QF_TIME_MINUTE_SUPPRESS | QF_TIME_SECOND_SUPPRESS |
> > > QF_TIME_STORAGE))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode));
> > > --
> > > 2.17.1
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67071): https://edk2.groups.io/g/devel/message/67071
Mute This Topic: https://groups.io/mt/78067357/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list