回复: [edk2-devel] [PATCH] MdeModulePkg: Correct the variable name.

[gaoliming]

Chao:
  Please update the commit message title as MdeModulePkg DisplayEngineDxe:
Correct the local variable name
  
  With this change, Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+66921+4905953+8761045 at groups.io
> <bounce+27952+66921+4905953+8761045 at groups.io> 代表
> gechao at greatwall.com.cn
> 发送时间: 2020年11月3日 10:01
> 收件人: devel at edk2.groups.io
> 抄送: dandan.bi at intel.com; eric.dong at intel.com; gechao
> <gechao at greatwall.com.cn>
> 主题: [edk2-devel] [PATCH] MdeModulePkg: Correct the variable name.
> 
> From: gechao <gechao at greatwall.com.cn>
> 
> Signed-off-by: gechao <gechao at greatwall.com.cn>
> ---
>  .../Universal/DisplayEngineDxe/FormDisplay.c     | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> index 3b034a1c82..a3898dc2ec 100644
> --- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> +++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> @@ -372,7 +372,7 @@ GetWidth (
>  {
> 
>    CHAR16                        *String;
> 
>    UINTN                         Size;
> 
> -  EFI_IFR_TEXT                  *TestOp;
> 
> +  EFI_IFR_TEXT                  *TextOp;
> 
>    UINT16                        ReturnWidth;
> 
>    FORM_DISPLAY_ENGINE_STATEMENT *Statement;
> 
> 
> 
> @@ -394,9 +394,9 @@ GetWidth (
>    // See if the second text parameter is really NULL
> 
>    //
> 
>    if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
> 
> -    TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> -    if (TestOp->TextTwo != 0) {
> 
> -      String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
> 
> +    TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> +    if (TextOp->TextTwo != 0) {
> 
> +      String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
> 
>        Size   = StrLen (String);
> 
>        FreePool (String);
> 
>      }
> 
> @@ -2166,7 +2166,7 @@ HasOptionString (
>    FORM_DISPLAY_ENGINE_STATEMENT   *Statement;
> 
>    CHAR16                          *String;
> 
>    UINTN                           Size;
> 
> -  EFI_IFR_TEXT                    *TestOp;
> 
> +  EFI_IFR_TEXT                    *TextOp;
> 
> 
> 
>    Size = 0;
> 
>    Statement = MenuOption->ThisTag;
> 
> @@ -2175,9 +2175,9 @@ HasOptionString (
>    // See if the second text parameter is really NULL
> 
>    //
> 
>    if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
> 
> -    TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> -    if (TestOp->TextTwo != 0) {
> 
> -      String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
> 
> +    TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> +    if (TextOp->TextTwo != 0) {
> 
> +      String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
> 
>        Size   = StrLen (String);
> 
>        FreePool (String);
> 
>      }
> 
> --
> 2.25.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#66921): https://edk2.groups.io/g/devel/message/66921
> Mute This Topic: https://groups.io/mt/78003643/4905953
> Group Owner: devel+owner at edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming at byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67204): https://edk2.groups.io/g/devel/message/67204
Mute This Topic: https://groups.io/mt/78151298/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-