[edk2-devel] [DxeHttpIoLib PATCH V5 0/3] Add Http IO Helper Library

[Abner Chang]

Yep, thanks for the reminder.  We will wait for the next stable tag.

> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
> gaoliming
> Sent: Tuesday, November 17, 2020 11:09 AM
> To: devel at edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang at hpe.com>; maciej.rabeda at linux.intel.com
> Cc: 'Jiaxin Wu' <jiaxin.wu at intel.com>; 'Siyuan Fu' <siyuan.fu at intel.com>;
> Wang, Nickle (HPS SW) <nickle.wang at hpe.com>
> Subject: 回复: [edk2-devel] [DxeHttpIoLib PATCH V5 0/3] Add Http IO Helper
> Library
> 
> Abner:
>   Please be aware that we are in soft feature freeze phase. This is a feature.
> So, this patch will be merged after the stable tag.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+67633+4905953+8761045 at groups.io
> > <bounce+27952+67633+4905953+8761045 at groups.io> 代表 Abner Chang
> > 发送时间: 2020年11月17日 9:52
> > 收件人: devel at edk2.groups.io; maciej.rabeda at linux.intel.com
> > 抄送: Jiaxin Wu <jiaxin.wu at intel.com>; Siyuan Fu <siyuan.fu at intel.com>;
> > Wang, Nickle (HPS SW) <nickle.wang at hpe.com>
> > 主题: Re: [edk2-devel] [DxeHttpIoLib PATCH V5 0/3] Add Http IO Helper
> > Library
> >
> > Thanks Maciej,
> > Just let me know once you merge it.
> >
> > > -----Original Message-----
> > > From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf
> > > Of Maciej Rabeda
> > > Sent: Monday, November 16, 2020 8:16 PM
> > > To: devel at edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > > <abner.chang at hpe.com>
> > > Cc: Jiaxin Wu <jiaxin.wu at intel.com>; Siyuan Fu
> > > <siyuan.fu at intel.com>; Wang, Nickle (HPS SW) <nickle.wang at hpe.com>
> > > Subject: Re: [edk2-devel] [DxeHttpIoLib PATCH V5 0/3] Add Http IO
> > > Helper Library
> > >
> > > Hi Abner,
> > >
> > > Sorry for the slack, got caught with other business.
> > > For the whole patch:
> > > Reviewed-by: Maciej Rabeda <maciej.rabeda at linux.intel.com>
> > >
> > > Thanks,
> > > Maciej
> > >
> > > On 03-Nov-20 06:26, Abner Chang wrote:
> > > > In v5: Add PCD to control the maximum size of total payload of HTTP
> > > >         chunk transfers.
> > > >
> > > > In v4: - Address the comments given by Maciej.
> > > >         - Add checking of "\r\n" notation on the Last-chunk and
> > > >           End-of-chunk.
> > > >
> > > > In v3: Address the comments given by Maciej.
> > > >
> > > > In v2: Revise HTTP Boot DXE to utilize HttpIoLib.
> > > >
> > > > In order to leverage HTTP IO related functions implemented in
> > > > HttpBootDxe for edk2 Redfish REST EX HTTP driver instance, we
> > > > would like to pull out HTTP IO related functions from HttpBootDxe
> > > > to a helper library under network package.
> > > >
> > > > This set of patches is for the new library HttpIoLib. HttpBootDxe
> > > > is also revised to utilize HttpIoLib. However we will need the
> > > > owner of HttpBootDxe to verify the functionality of HTTP boot
> > > > becuase I don't have the environment for that.
> > > >
> > > > Signed-off-by: Abner Chang <abner.chang at hpe.com>
> > > >
> > > > Cc: Maciej Rabeda <maciej.rabeda at linux.intel.com>
> > > > Cc: Jiaxin Wu <jiaxin.wu at intel.com>
> > > > Cc: Siyuan Fu <siyuan.fu at intel.com>
> > > > Cc: Nickle Wang <nickle.wang at hpe.com>
> > > >
> > > > Abner Chang (3):
> > > >    NetworkPkg/Library: Implementation of Http IO Helper Library
> > > >    NetworkPkg: Add Http IO Helper Library to NetworkPkg
> > > >    NetworkPkg/HttpBootDxe: Utilize HttpIoLib
> > > >
> > > >   NetworkPkg/HttpBootDxe/HttpBootDxe.h          |   3 +-
> > > >   NetworkPkg/HttpBootDxe/HttpBootDxe.inf        |   2 +
> > > >   NetworkPkg/HttpBootDxe/HttpBootSupport.c      | 431 +--------
> > > >   NetworkPkg/HttpBootDxe/HttpBootSupport.h      | 189 +---
> > > >   NetworkPkg/Include/Library/HttpIoLib.h        | 328 +++++++
> > > >   .../Library/DxeHttpIoLib/DxeHttpIoLib.c       | 853
> > ++++++++++++++++++
> > > >   .../Library/DxeHttpIoLib/DxeHttpIoLib.inf     |  46 +
> > > >   .../Library/DxeHttpIoLib/DxeHttpIoLib.uni     |  13 +
> > > >   NetworkPkg/NetworkLibs.dsc.inc                |   5 +-
> > > >   NetworkPkg/NetworkPkg.dec                     |  10 +-
> > > >   NetworkPkg/NetworkPkg.dsc                     |   1 +
> > > >   11 files changed, 1260 insertions(+), 621 deletions(-)
> > > >   create mode 100644 NetworkPkg/Include/Library/HttpIoLib.h
> > > >   create mode 100644
> > NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c
> > > >   create mode 100644
> > NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf
> > > >   create mode 100644
> > NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.uni
> > > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67640): https://edk2.groups.io/g/devel/message/67640
Mute This Topic: https://groups.io/mt/78309196/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-