[edk2-devel] [PATCH v3 3/3] ArmPkg: add Universal/Smbios as a generic SMBIOS library

[Rebecca Cran]

On 11/16/20 6:43 AM, Sami Mujawar wrote:

> I have reviewed the following files from this patch and my responses are inline marked [SAMI].
>    ArmPkg/Include/Chipset/AArch64.h
>    ArmPkg/Include/Library/ArmLib.h
>    ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c
>    ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h
>    ArmPkg/Library/ArmLib/AArch64/AArch64Support.S
>    ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S
>    ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S
>    ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm
>    ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c
>    ArmPkg/Library/ArmLib/ArmLibPrivate.h
>
> Is it possible to split this patch into smaller patches, please? It will then be easier to review the remaining files.

Thanks! I've split the patch into much smaller changes and incorporated 
your fixes. I'll send out a v4 soon.


-- 
Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67642): https://edk2.groups.io/g/devel/message/67642
Mute This Topic: https://groups.io/mt/78172736/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-