[edk2-devel] [PATCH v1 04/12] ArmPkg: Introduce support for PcdFfaEnable

[Sami Mujawar]

Hi Sughosh,

Please find my response inline marked [SAMI].

With that changed:
Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

Regards,

Sami Mujawar

-----Original Message-----
From: Sughosh Ganu <sughosh.ganu at linaro.org> 
Sent: 21 October 2020 12:32 PM
To: devel at edk2.groups.io
Cc: Ard Biesheuvel <Ard.Biesheuvel at arm.com>; Sami Mujawar <Sami.Mujawar at arm.com>; Jiewen Yao <jiewen.yao at intel.com>; Sughosh Ganu <sughosh.ganu at linaro.org>
Subject: [PATCH v1 04/12] ArmPkg: Introduce support for PcdFfaEnable

The Secure Partition(SP) can request services from the Secure
Partition Manager Core(SPMC) either through FF-A calls or through the
existing SVC calls. Add a feature flag Pcd for enabling the FF-A
method -- when this is set to FALSE, the SP uses the existing SVC
calls for making the requests.

Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
---
 ArmPkg/ArmPkg.dec | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
index eaf1072d9e..979f3e2699 100644
--- a/ArmPkg/ArmPkg.dec
+++ b/ArmPkg/ArmPkg.dec
@@ -78,6 +78,9 @@
   # Define if the GICv3 controller should use the GICv2 legacy
   gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042
 
+  # Used to select method for requesting services from S-EL1
[SAMI] Can you follow the documentation style for PCD definition as done in MdePkg\MdePkg.dec, please?
More information can be found at https://github.com/tianocore-docs/edk2-DecSpecification/blob/master/3_edk_ii_dec_file_format/310_pcd_sections.md
[/SAMI]
+  gArmTokenSpaceGuid.PcdFfaEnable|FALSE|BOOLEAN|0x0000005B
+
 [PcdsFeatureFlag.ARM]
   # Whether to map normal memory as non-shareable. FALSE is the safe choice, but
   # TRUE may be appropriate to fix performance problems if you don't care about
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67704): https://edk2.groups.io/g/devel/message/67704
Mute This Topic: https://groups.io/mt/77703651/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-