回复: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer double free in CryptPkcs7VerifyEku

[gaoliming]

Kun:
 This is a bug fix. It passed code review. Do you request to merge it for
this stable tag 202011?

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+67567+4905953+8761045 at groups.io
> <bounce+27952+67567+4905953+8761045 at groups.io> 代表 Yao, Jiewen
> 发送时间: 2020年11月14日 8:32
> 收件人: Kun Qin <kun.q at outlook.com>; devel at edk2.groups.io
> 抄送: Wang, Jian J <jian.j.wang at intel.com>; Lu, XiaoyuX
> <xiaoyux.lu at intel.com>; Jiang, Guomin <guomin.jiang at intel.com>; Yao,
> Jiewen <jiewen.yao at intel.com>
> 主题: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer
> double free in CryptPkcs7VerifyEku
> 
> Sorry, I missed this email.
> 
> Reviewed-by: Jiewen Yao <Jiewen.yao at intel.com>
> 
> 
> > -----Original Message-----
> > From: Kun Qin <kun.q at outlook.com>
> > Sent: Wednesday, October 21, 2020 10:32 AM
> > To: devel at edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang at intel.com>; Lu, XiaoyuX
> > <xiaoyux.lu at intel.com>; Yao, Jiewen <jiewen.yao at intel.com>; Jiang,
> > Guomin <guomin.jiang at intel.com>
> > Subject: [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer double free
in
> > CryptPkcs7VerifyEku
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2459
> >
> > SignerCert is part of Pkcs7 instance when both have valid content.
OpenSLL
> > PKCS7_free function will release the memory of SignerCert when
applicable.
> > Freeing SignerCert with X509_free again might cause page fault if use-
> > after-free guard is enabled.
> >
> > Cc: Jian J Wang <jian.j.wang at intel.com>
> > Cc: Xiaoyu Lu <xiaoyux.lu at intel.com>
> > Cc: Jiewen Yao <jiewen.yao at intel.com>
> > Cc: Guomin Jiang <guomin.jiang at intel.com>
> >
> > Signed-off-by: Kun Qin <kun.q at outlook.com>
> > ---
> >  CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> > index c9fdb65b99d1..40cc39afe7dd 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> > @@ -508,10 +508,6 @@ Exit:
> >      free (SignedData);
> >
> >    }
> >
> >
> >
> > -  if (SignerCert != NULL) {
> >
> > -    X509_free (SignerCert);
> >
> > -  }
> >
> > -
> >
> >    if (Pkcs7 != NULL) {
> >
> >      PKCS7_free (Pkcs7);
> >
> >    }
> >
> > --
> > 2.28.0.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67743): https://edk2.groups.io/g/devel/message/67743
Mute This Topic: https://groups.io/mt/78383601/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-