[edk2-devel] [PATCH v1 2/2] UefiCpuPkg/CpuCacheInfoLib: Add new CpuCacheInfoLib.

[Laszlo Ersek]

On 11/20/20 06:06, Ni, Ray wrote:
> Laszlo,
> The library can be used by code that produces SMBIOS_TABLE_TYPE7 SMBIOS table.

Great information, thank you! Exactly the kind that I wanted to hear.

Please add this sentence to the commit message (either via a v2 posting,
or at merge time, as you see fit).

Thanks!
Laszlo

> It's true that right now such code is not in open source.
> 
> Thanks,
> Ray
> 
>> -----Original Message-----
>> From: Laszlo Ersek <lersek at redhat.com>
>> Sent: Thursday, November 19, 2020 5:52 PM
>> To: Lou, Yun <yun.lou at intel.com>; devel at edk2.groups.io
>> Cc: Ni, Ray <ray.ni at intel.com>; Dong, Eric <eric.dong at intel.com>; Kumar, Rahul1 <rahul1.kumar at intel.com>
>> Subject: Re: [PATCH v1 2/2] UefiCpuPkg/CpuCacheInfoLib: Add new CpuCacheInfoLib.
>>
>> On 11/19/20 03:36, jasonlouyun wrote:
>>> This library uses a platform agnostic algorithm to get CPU cache
>>> information. It provides user with an API(GetCpuCacheInfo) to get
>>> detailed CPU cache information by each package, each core type
>>> included in this package, and each cache level & type.
>>>
>>> Signed-off-by: Jason Lou <yun.lou at intel.com>
>>> Cc: Ray Ni <ray.ni at intel.com>
>>> Cc: Eric Dong <eric.dong at intel.com>
>>> Cc: Laszlo Ersek <lersek at redhat.com>
>>> Cc: Rahul Kumar <rahul1.kumar at intel.com>
>>> ---
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c         | 602 ++++++++++++++++++++
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCacheInfoLib.c      | 131 +++++
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/PeiCpuCacheInfoLib.c      | 130 +++++
>>>  UefiCpuPkg/Include/Library/CpuCacheInfoLib.h                 |  68 +++
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.uni       |  15 +
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCacheInfoLib.inf    |  43 ++
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/InternalCpuCacheInfoLib.h |  64 +++
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/PeiCpuCacheInfoLib.inf    |  43 ++
>>>  UefiCpuPkg/UefiCpuPkg.dec                                    |   3 +
>>>  UefiCpuPkg/UefiCpuPkg.dsc                                    |   4 +
>>>  10 files changed, 1103 insertions(+)
>>
>> I defer this review to the other UefiCpuPkg reviewers / maintainers.
>>
>> Two superficial suggestions:
>>
>> - please file a TianoCore feature request BZ, and reference it in the
>> commit messages in this series
>>
>> - *at least one* of the commit message and the bugzilla ticket, but
>> preferably both, should describe the use case. In other words, what
>> platforms intend to use the new library (especially if they are open
>> source in edk2-platforms or otherwise), and what use cases will benefit
>> from having cache information.
>>
>> Otherwise, this library is just dead code in edk2. I don't insist that
>> the consumers of this library be open source, but I do insist that
>> *something* be publicly explained about the use case.
>>
>> Thanks
>> Laszlo
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67761): https://edk2.groups.io/g/devel/message/67761
Mute This Topic: https://groups.io/mt/78357119/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-