[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion
Samer El-Haj-Mahmoud
samer.el-haj-mahmoud at arm.com
Mon Nov 23 12:46:13 UTC 2020
Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>
> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Sent: Saturday, November 21, 2020 11:08 AM
> To: EDK II Development <devel at edk2.groups.io>
> Cc: Eric Jin <eric.jin at intel.com>; G Edhaya Chandran
> <Edhaya.Chandran at arm.com>; Barton Gao <gaojie at byosoft.com.cn>;
> Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>; Heinrich
> Schuchardt <xypron.glpk at gmx.de>
> Subject: [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion
>
> The functional tests for OpenEx() use RecordAssertion() statements that lack
> a print code for the Tpl argument. This leads to a segmentation violation.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
> .../SimpleFileSystemExBBTestFunction_OpenEx.c | 8 ++++----
> .../SimpleFileSystemExBBTestFunction_OpenEx.c | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c
> index c2bf9b4fdc92..193383993cbe 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackB
> +++ oxTest/SimpleFileSystemExBBTestFunction_OpenEx.c
> @@ -1155,7 +1155,7 @@ BBTestOpenExBasicTestCheckpoint1_Test1_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid027,
> L"OpenEx() Basic Test - checkpoint1 ----Test1----Async",
> - L"%a:%d: FileIoEntity->Tpl, Status - %r, File Name - %",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -2152,7 +2152,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test3_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid039,
> L"OpenEx() Basic Test - checkpoint1 ---Async",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -2656,7 +2656,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test4_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid043,
> L"OpenEx() Basic Test - checkpoint1 ---Async -- Test4----Open
> File",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -3302,7 +3302,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test5_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid047,
> L"OpenEx() Basic Test - checkpoint1 ---Async -- Test5---Open File",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c
> index 70ec88f1c065..894d42fc370d 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackB
> +++ oxTest/SimpleFileSystemExBBTestFunction_OpenEx.c
> @@ -1155,7 +1155,7 @@ BBTestOpenExBasicTestCheckpoint1_Test1_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid027,
> L"OpenEx() Basic Test - checkpoint1 ----Test1----Async",
> - L"%a:%d: FileIoEntity->Tpl, Status - %r, File Name - %",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -2152,7 +2152,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test3_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid039,
> L"OpenEx() Basic Test - checkpoint1 ---Async",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -2656,7 +2656,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test4_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid043,
> L"OpenEx() Basic Test - checkpoint1 ---Async -- Test4----Open
> File",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -3302,7 +3302,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test5_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid047,
> L"OpenEx() Basic Test - checkpoint1 ---Async -- Test5---Open File",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl,
> --
> 2.29.2
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67801): https://edk2.groups.io/g/devel/message/67801
Mute This Topic: https://groups.io/mt/78413918/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list