[edk2-devel] [PATCH 0/5] OvmfPkg: Fix Bhyve code formatting and style problems

[Rebecca Cran]

There are several problems with the code style and formatting in Bhyve related files.
These include using structs without typedef'ing them, wrong indentation (e.g. three
spaces instead of two), and UINTN/UINT32 mix-ups which cause build errors when
using VS 2019.

I've taken this opportunity to also change the INF and DSC versions to decimal and
bump the version to 1.29 for INF files and 1.30 for the DSC.

Rebecca Cran (5):
  OvmfPkg: Fix BhyveFwCtlLib build with VS2019
  OvmfPkg: Improve code style/formatting in BhyveFwCtlLib.c
  OvmfPkg: Fix style of BhyveFwCtlLib.inf
  OvmfPkg: Improve style and formatting in BhyveFwCtlLib.h
  OvmfPkg/Bhyve: Fix various style issues

 OvmfPkg/Bhyve/BhyveX64.dsc                    |   2 +-
 .../Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf |  18 +-
 OvmfPkg/Bhyve/AcpiTables/AcpiTables.inf       |  10 +-
 OvmfPkg/Bhyve/BhyveRfbDxe/BhyveRfbDxe.inf     |   8 +-
 OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf     |  12 +-
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf   |  10 +-
 .../Library/BhyveFwCtlLib/BhyveFwCtlLib.inf   |   5 +-
 OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h  |  10 +-
 OvmfPkg/Bhyve/AcpiTables/Platform.h           |   2 +-
 OvmfPkg/Bhyve/BhyveRfbDxe/Gop.h               |   6 +-
 OvmfPkg/Bhyve/PlatformPei/Cmos.h              |   6 +-
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.h     |   7 +-
 OvmfPkg/Include/Library/BhyveFwCtlLib.h       |  24 +--
 OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c  |   3 +-
 OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c         |   2 +-
 OvmfPkg/Bhyve/PlatformPei/Fv.c                |   2 +-
 OvmfPkg/Bhyve/PlatformPei/Platform.c          |   2 +-
 OvmfPkg/Library/BhyveFwCtlLib/BhyveFwCtlLib.c | 162 +++++++++---------
 18 files changed, 143 insertions(+), 148 deletions(-)

-- 
2.29.2.windows.2




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68063): https://edk2.groups.io/g/devel/message/68063
Mute This Topic: https://groups.io/mt/78602180/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-