[edk2-devel] [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table

Gao, Zhichao zhichao.gao at intel.com
Tue Apr 6 02:04:17 UTC 2021


Reviewed-by: Zhichao Gao <zhichao.gao at intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Rebecca Cran <rebecca at nuviainc.com>
> Sent: Wednesday, March 31, 2021 9:55 AM
> To: devel at edk2.groups.io
> Cc: Rebecca Cran <rebecca at nuviainc.com>; Ni, Ray <ray.ni at intel.com>; Gao,
> Zhichao <zhichao.gao at intel.com>
> Subject: [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table
> 
> The SystemEnclosureTypeTable in QueryTable.c contained a couple of errors:
> value 0x10 is "Lunch Box" not "Main Server Chassis", and the Sub Notebook
> value was repeated as 0x13 when that entry is for "SubChassis". The entries
> in-between needed adjusted.
> 
> Signed-off-by: Rebecca Cran <rebecca at nuviainc.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> index d0796a0e5141..39a3e3c0895b 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> +++ c
> @@ -188,20 +188,20 @@ TABLE_ITEM  SystemEnclosureTypeTable[] = {
>    },
>    {
>      0x10,
> +    L"  Lunch Box"
> +  },
> +  {
> +    0x11,
>      L"  Main Server Chassis"
>    },
>    {
> -    0x11,
> +    0x12,
>      L"  Expansion Chassis"
>    },
>    {
> -    0x12,
> +    0x13,
>      L"  SubChassis"
>    },
> -  {
> -    0x13,
> -    L"  Sub Notebook"
> -  },
>    {
>      0x14,
>      L"  Bus Expansion Chassis"
> --
> 2.26.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73707): https://edk2.groups.io/g/devel/message/73707
Mute This Topic: https://groups.io/mt/81741180/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list