[edk2-devel] [PATCH] MinPlatformPkg: Add PcdFlashMicrocodeOffset

[Ni, Ray]

> 1. Maybe we can align with IntelFsp2WrapperPkg which have this PCD
> default value as 0x90 for typical cases?
Sure. I will update to 0x90.

> 2. Since we already have MicrocodeOffset PCD there, to prevent from
> confusing, how about renaming it to something like
> PcdFlashMicrocodeBypassBytes?

BypassBytes might not be a clear name for indicating the PCD meaning.
How about "PcdMicrcocodeOffsetInFv"?

> 3. Please add comments to describe this particular PCD meaning, because it is
> different from others (flash map definition PCD)

I will.

> 
> >
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemoryBase|0x00000000|
> UIN
> > T32|0x20000004
> >
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemorySize|0x00000000|
> UIN
> > T32|0x20000005--
> > 2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73828): https://edk2.groups.io/g/devel/message/73828
Mute This Topic: https://groups.io/mt/81936936/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-