[edk2-devel] [edk2-platforms][PATCH v2 0/2] MinPlatformPkg: Improve NULL ACPI table lib maintainability

Nate DeSimone nathaniel.l.desimone at intel.com
Fri Apr 9 21:50:00 UTC 2021


The series has been pushed as 3204cbfe~..ade2b32

Thanks,
Nate

-----Original Message-----
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Michael Kubacki
Sent: Thursday, April 8, 2021 2:25 PM
To: devel at edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>; Dong, Eric <eric.dong at intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/2] MinPlatformPkg: Improve NULL ACPI table lib maintainability

From: Michael Kubacki <michael.kubacki at microsoft.com>

This series makes some simple changes to the organization of BoardAcpiEnableLibNull and BoardAcpiTableLibNull to better align the library instances with patterns typically used so they are easier to integrate into platforms.

The following issues are resolved:
1. Sharing of a directory with another unrelated library instance.
2. The directory name "BoardAcpiLibNull" is not directly related to
   either library instance name in the directory.
3. The library instances have unnecessary dependencies.
4. The BASE_NAME does not indicate the library instance is the NULL
   instance.
5. The C source file names do not match the INF file name making
   finding the C source by search more cumbersome than needed.

V2 changes:
1. Remove Base.h from BoardAcpiEnableLibNull.c and
   BoardAcpiTableLibNull.c

Cc: Chasel Chiu <chasel.chiu at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>
Cc: Eric Dong <eric.dong at intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki at microsoft.com>

Michael Kubacki (2):
  MinPlatformPkg/BoardAcpiEnableLibNull: Improve maintainability
  MinPlatformPkg/BoardAcpiTableLibNull: Improve maintainability

 Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiEnableLib.c => BoardAcpiEnableLibNull/BoardAcpiEnableLibNull.c} |  3 ---
 Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiTableLib.c => BoardAcpiTableLibNull/BoardAcpiTableLibNull.c}    |  3 ---
 Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull => BoardAcpiEnableLibNull}/BoardAcpiEnableLibNull.inf                    | 12 ++++--------
 Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull => BoardAcpiTableLibNull}/BoardAcpiTableLibNull.inf                      | 12 ++++--------
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc                                                                                      |  8 ++++----
 5 files changed, 12 insertions(+), 26 deletions(-)  rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiEnableLib.c => BoardAcpiEnableLibNull/BoardAcpiEnableLibNull.c} (73%)  rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiTableLib.c => BoardAcpiTableLibNull/BoardAcpiTableLibNull.c} (73%)  rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull => BoardAcpiEnableLibNull}/BoardAcpiEnableLibNull.inf (67%)  rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull => BoardAcpiTableLibNull}/BoardAcpiTableLibNull.inf (67%)

--
2.28.0.windows.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73880): https://edk2.groups.io/g/devel/message/73880
Mute This Topic: https://groups.io/mt/81953909/1767664
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone at intel.com]
-=-=-=-=-=-=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73915): https://edk2.groups.io/g/devel/message/73915
Mute This Topic: https://groups.io/mt/81953909/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list