[edk2-devel] [edk2-platforms][PATCH V2 3/6] Platform/Sgi: fix CPU acpi-id for RD-V1-MC platform

Sami Mujawar sami.mujawar at arm.com
Mon Apr 12 11:21:19 UTC 2021


Hi Pranav,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

Regards,

Sami Mujawar

On 01/04/2021, 06:36, "Pranav Madhu" <pranav.madhu at arm.com> wrote:

    Fix the incorrect ACPI _UID (Unique ID) object for CPU devices listed
    for the RD-V1-MC platform.

    Signed-off-by: Pranav Madhu <pranav.madhu at arm.com>
    ---
     Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Madt.aslc | 24 ++++++++++----------
     1 file changed, 12 insertions(+), 12 deletions(-)

    diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Madt.aslc b/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Madt.aslc
    index 0da56ed2a39b..9b3e4f2be370 100644
    --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Madt.aslc
    +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Madt.aslc
    @@ -69,55 +69,55 @@ STATIC EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE Madt = {

         // Chip 1
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core0
    -      0, 0, GET_MPID(0x01000000ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 4, GET_MPID(0x01000000ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core1
    -      0, 1, GET_MPID(0x01000100ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 5, GET_MPID(0x01000100ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core2
    -      0, 2, GET_MPID(0x01000200ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 6, GET_MPID(0x01000200ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core3
    -      0, 3, GET_MPID(0x01000300ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 7, GET_MPID(0x01000300ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),

         // Chip 2
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core0
    -      0, 0, GET_MPID(0x02000000ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 8, GET_MPID(0x02000000ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core1
    -      0, 1, GET_MPID(0x02000100ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 9, GET_MPID(0x02000100ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core2
    -      0, 2, GET_MPID(0x02000200ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 10, GET_MPID(0x02000200ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core3
    -      0, 3, GET_MPID(0x02000300ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 11, GET_MPID(0x02000300ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),

         // Chip 3
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core0
    -      0, 0, GET_MPID(0x03000000ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 12, GET_MPID(0x03000000ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core1
    -      0, 1, GET_MPID(0x03000100ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 13, GET_MPID(0x03000100ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core2
    -      0, 2, GET_MPID(0x03000200ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 14, GET_MPID(0x03000200ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
         EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Zeus core3
    -      0, 3, GET_MPID(0x03000300ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
    +      0, 15, GET_MPID(0x03000300ULL, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
           FixedPcdGet32 (PcdGicDistributorBase),
           0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
       },
    -- 
    2.17.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73947): https://edk2.groups.io/g/devel/message/73947
Mute This Topic: https://groups.io/mt/81769418/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list