回复: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list assumptions
gaoliming
gaoliming at byosoft.com.cn
Tue Apr 13 01:28:21 UTC 2021
Mike:
Is this update for new ARCH support? With this patch set, new ARCH support
doesn't need to modify BaseTools. Right?
For this patch set 3/3 BaseTools/Source, I may suggest to split it to two
patches, one is for C tools, another is for Python tools.
For other patch, they are good to me. Reviewed-by: Liming Gao
<gaoliming at byosoft.com.cn>
Thanks
Liming
> -----邮件原件-----
> 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Michael D
> Kinney
> 发送时间: 2021年4月8日 14:33
> 收件人: devel at edk2.groups.io
> 抄送: Jiewen Yao <jiewen.yao at intel.com>; Jian J Wang
> <jian.j.wang at intel.com>; Xiaoyu Lu <xiaoyux.lu at intel.com>; Guomin Jiang
> <guomin.jiang at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu at intel.com>; Bob Feng <bob.c.feng at intel.com>;
> Yuwei Chen <yuwei.chen at intel.com>; Andrew Fish <afish at apple.com>;
> Abner Chang <abner.chang at hpe.com>
> 主题: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list
> assumptions
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3308
>
> The EDK II Build Specifications do not restrict the set of
> CPU architectures that can be supported. Remove places in
> the EDK II that assume a fixed set of CPU architectures.
>
> Remove build breaks in the following tools and DEFINES when a check
against
> a fixed set of CPU architectures is made.
>
> * Build
> * GenFds
> * TargetTool
> * GenFw
> * SIXTY_FOUR_BIT and THIRTY_TWO_BIT
> * EFI_IMAGE_MACHINE_TYPE_SUPPORTED
> * EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED
> * EFI_REMOVABLE_MEDIA_FILE_NAME
>
> Cc: Jiewen Yao <jiewen.yao at intel.com>
> Cc: Jian J Wang <jian.j.wang at intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu at intel.com>Cc
> Cc: Guomin Jiang <guomin.jiang at intel.com>
> Cc: Liming Gao <gaoliming at byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu at intel.com>
> Cc: Bob Feng <bob.c.feng at intel.com>
> Cc: Yuwei Chen <yuwei.chen at intel.com>
> Cc: Andrew Fish <afish at apple.com>
> Cc: Abner Chang <abner.chang at hpe.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney at intel.com>
>
> Michael D Kinney (3):
> MdePkg/Include: Allow CPU specific defines to be predefined
> CryptoPkg/Library/Include: Allow CPU specific defines to be predefined
> BaseTools/Source: Remove CPU architecture assumptions
>
> BaseTools/Source/C/GenFw/Elf32Convert.c | 5 ++---
> BaseTools/Source/C/GenFw/Elf64Convert.c | 5 ++---
> BaseTools/Source/Python/GenFds/FdfParser.py | 4 +---
> BaseTools/Source/Python/TargetTool/TargetTool.py | 4 ++--
> BaseTools/Source/Python/build/buildoptions.py | 4 ++--
> CryptoPkg/Library/Include/CrtLibSupport.h | 2 ++
> MdePkg/Include/Uefi/UefiBaseType.h | 4 +++-
> MdePkg/Include/Uefi/UefiSpec.h | 4 +++-
> 8 files changed, 17 insertions(+), 15 deletions(-)
>
> --
> 2.31.1.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73998): https://edk2.groups.io/g/devel/message/73998
Mute This Topic: https://groups.io/mt/82055034/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list