[edk2-devel] [PATCH] RedfishPkg: Add EDK2 Redfish Foundation diagrams

[Laszlo Ersek]

On 04/13/21 12:44, Chang, Abner (HPS SW/FW Technologist) wrote:
> 
> 
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek at redhat.com]
>> Sent: Tuesday, April 13, 2021 6:19 PM
>> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang at hpe.com>;
>> devel at edk2.groups.io
>> Cc: Jiaxin Wu <jiaxin.wu at intel.com>; Ting Ye <ting.ye at intel.com>; Siyuan Fu
>> <siyuan.fu at intel.com>; Fan Wang <fan.wang at intel.com>; Jiewen Yao
>> <jiewen.yao at intel.com>; Wang, Nickle (HPS SW) <nickle.wang at hpe.com>;
>> Andrew Fish <afish at apple.com>; Leif Lindholm <leif at nuviainc.com>;
>> Michael D Kinney <michael.d.kinney at intel.com>
>> Subject: Re: [PATCH] RedfishPkg: Add EDK2 Redfish Foundation diagrams
>>
>> On 04/13/21 02:10, Abner Chang wrote:
>>> The Readme.md to delineate the EFK2 Redfish foundation driver
>>> stack.
>>>
>>> Signed-off-by: Abner Chang <abner.chang at hpe.com>
>>>
>>> Cc: Jiaxin Wu <jiaxin.wu at intel.com>
>>> Cc: Ting Ye <ting.ye at intel.com>
>>> Cc: Siyuan Fu <siyuan.fu at intel.com>
>>> Cc: Fan Wang <fan.wang at intel.com>
>>> Cc: Jiewen Yao <jiewen.yao at intel.com>
>>> Cc: Nickle Wang <nickle.wang at hpe.com>
>>> Cc: Andrew Fish <afish at apple.com>
>>> Cc: Laszlo Ersek <lersek at redhat.com>
>>> Cc: Leif Lindholm <leif at nuviainc.com>
>>> Cc: Michael D Kinney <michael.d.kinney at intel.com>
>>> ---
>>>  RedfishPkg/Readme.md                          | 117 ++++++++++++++++++
>>>  .../Documents/Media/RedfishDriverStack.png    | Bin 0 -> 157408 bytes
>>>  2 files changed, 117 insertions(+)
>>>  create mode 100644 RedfishPkg/Readme.md
>>>  create mode 100644
>> RedfishPkg/Documents/Media/RedfishDriverStack.png
>>
>> Why am I expected to review this?
> I thought you are the steward and may give comments on the readme markdown with image of the diagrams under RedfishPkg. But you did have comments on the RFC so that's another reason to invite you for the review, not mandatory though :D
> Same message to Andrew, Leif and Mike.

Right... but my earlier comments suggested SVG, and Mike suggested
another plaintext-based graphics format (sorry the name eludes me at the
moment). So why is there a PNG in this patch?

Thanks
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74042): https://edk2.groups.io/g/devel/message/74042
Mute This Topic: https://groups.io/mt/82054543/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-