[edk2-devel] [PATCH EDK2 v1 1/1] SecurityPkg/FvReportPei: remove redundant sizeof

[Laszlo Ersek]

On 04/13/21 14:33, Wenyi Xie wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3333
> 
> In function InstallPreHashFvPpi, when calculatuing the size

(1) s/calculatuing/calculating/

(2) I suggest remarking, in the commit message, that this bug does not
lead to buffer overflow, given that "sizeof (HASH_INFO)" is 4, whereas
"sizeof (sizeof (HASH_INFO))" is 4 or 8.

> of struct HASH_INFO，sizeof is used twice.
> 
> Cc: Jiewen Yao <jiewen.yao at intel.com>
> Cc: Jian J Wang <jian.j.wang at intel.com>
> Cc: Laszlo Ersek <lersek at redhat.com>
> Signed-off-by: Wenyi Xie <xiewenyi2 at huawei.com>
> ---
>  SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/SecurityPkg/FvReportPei/FvReportPei.c b/SecurityPkg/FvReportPei/FvReportPei.c
> index d709760ea3ce..e82413e090c0 100644
> --- a/SecurityPkg/FvReportPei/FvReportPei.c
> +++ b/SecurityPkg/FvReportPei/FvReportPei.c
> @@ -67,7 +67,7 @@ InstallPreHashFvPpi (
>    HASH_INFO                                         *HashInfo;
>  
>    PpiSize = sizeof (EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI)
> -            + sizeof (sizeof (HASH_INFO))
> +            + sizeof (HASH_INFO)
>              + HashSize;
>  
>    PreHashedFvPpi = AllocatePool (PpiSize);
> 

>From my perspective:

Reviewed-by: Laszlo Ersek <lersek at redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74044): https://edk2.groups.io/g/devel/message/74044
Mute This Topic: https://groups.io/mt/82063417/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-