[edk2-devel] [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in tools_def.template
Michael D Kinney
michael.d.kinney at intel.com
Tue Apr 13 14:17:37 UTC 2021
Hi,
I also noticed a many duplications for MAKE_FLAGS where a more extensive cleanup is possible.
I decided to fix the typos first and then do a 2nd patch to remove all duplicates.
Mike
> -----Original Message-----
> From: Chen, Christine <yuwei.chen at intel.com>
> Sent: Tuesday, April 13, 2021 12:39 AM
> To: devel at edk2.groups.io; Chen, Christine <yuwei.chen at intel.com>; Kinney, Michael D <michael.d.kinney at intel.com>
> Cc: Feng, Bob C <bob.c.feng at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>
> Subject: RE: [edk2-devel] [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in tools_def.template
>
> Hi Mike,
>
> I have a minor comment. As you change the '*_MAKE_FLAG' to '*_MAKE_FLAGS', there will have two same '*_MAKE_FLAGS' for
> the tool chain. It may be duplicated. Would it be better if just delete "* _MAKE_FLAG"?
>
> Thanks,
> Christine
>
> > -----Original Message-----
> > From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Yuwei
> > Chen
> > Sent: Monday, April 12, 2021 9:48 AM
> > To: Kinney, Michael D <michael.d.kinney at intel.com>; devel at edk2.groups.io
> > Cc: Feng, Bob C <bob.c.feng at intel.com>; Liming Gao
> > <gaoliming at byosoft.com.cn>
> > Subject: Re: [edk2-devel] [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos
> > in tools_def.template
> >
> > Reviewed-by: Yuwei Chen<yuwei.chen at intel.com>
> >
> > > -----Original Message-----
> > > From: Kinney, Michael D <michael.d.kinney at intel.com>
> > > Sent: Saturday, April 10, 2021 6:00 AM
> > > To: devel at edk2.groups.io
> > > Cc: Feng, Bob C <bob.c.feng at intel.com>; Liming Gao
> > > <gaoliming at byosoft.com.cn>; Chen, Christine <yuwei.chen at intel.com>
> > > Subject: [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in
> > > tools_def.template
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3313
> > >
> > > Change MAKE_FLAG to MAKE_FLAGS to match required name from EDK II
> > > Build Specifications for VS20xx tool chains.
> > >
> > > Cc: Bob Feng <bob.c.feng at intel.com>
> > > Cc: Liming Gao <gaoliming at byosoft.com.cn>
> > > Cc: Yuwei Chen <yuwei.chen at intel.com>
> > > Signed-off-by: Michael D Kinney <michael.d.kinney at intel.com>
> > > ---
> > > BaseTools/Conf/tools_def.template | 16 ++++++++--------
> > > 1 file changed, 8 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/BaseTools/Conf/tools_def.template
> > > b/BaseTools/Conf/tools_def.template
> > > index 933b3160fd2b..c6c9edf5a0d7 100755
> > > --- a/BaseTools/Conf/tools_def.template
> > > +++ b/BaseTools/Conf/tools_def.template
> > > @@ -1,5 +1,5 @@
> > > #
> > > -# Copyright (c) 2006 - 2018, Intel Corporation. All rights
> > > reserved.<BR>
> > > +# Copyright (c) 2006 - 2021, Intel Corporation. All rights
> > > +reserved.<BR>
> > > # Portions copyright (c) 2008 - 2009, Apple Inc. All rights
> > > reserved.<BR> # Portions copyright (c) 2011 - 2019, ARM Ltd. All
> > > rights reserved.<BR> # Copyright (c) 2015, Hewlett-Packard
> > > Development Company, L.P.<BR> @@ -
> > > 531,7 +531,7 @@ NOOPT_VS2008_X64_DLINK_FLAGS = /NOLOGO
> > /NODEFAULTLIB
> > > /IGNORE:4001 /OPT:REF /OPT
> > > *_VS2008x86_*_*_FAMILY = MSFT
> > >
> > > *_VS2008x86_*_MAKE_PATH = DEF(VS2008x86_BIN)\nmake.exe
> > > -*_VS2008x86_*_MAKE_FLAG = /nologo
> > > +*_VS2008x86_*_MAKE_FLAGS = /nologo
> > > *_VS2008x86_*_RC_PATH = DEF(WINSDK_BIN)\rc.exe
> > >
> > > *_VS2008x86_*_MAKE_FLAGS = /nologo
> > > @@ -765,7 +765,7 @@ NOOPT_VS2010_X64_DLINK_FLAGS = /NOLOGO
> > > /NODEFAULTLIB /IGNORE:4001 /OPT:REF /OPT
> > > *_VS2010x86_*_*_FAMILY = MSFT
> > >
> > > *_VS2010x86_*_MAKE_PATH = DEF(VS2010x86_BIN)\nmake.exe
> > > -*_VS2010x86_*_MAKE_FLAG = /nologo
> > > +*_VS2010x86_*_MAKE_FLAGS = /nologo
> > > *_VS2010x86_*_RC_PATH = DEF(WINSDK7x86_BIN)\rc.exe
> > >
> > > *_VS2010x86_*_MAKE_FLAGS = /nologo
> > > @@ -999,7 +999,7 @@ NOOPT_VS2012_X64_DLINK_FLAGS = /NOLOGO
> > > /NODEFAULTLIB /IGNORE:4001 /OPT:REF /OPT
> > > *_VS2012x86_*_*_FAMILY = MSFT
> > >
> > > *_VS2012x86_*_MAKE_PATH = DEF(VS2012x86_BIN)\nmake.exe
> > > -*_VS2012x86_*_MAKE_FLAG = /nologo
> > > +*_VS2012x86_*_MAKE_FLAGS = /nologo
> > > *_VS2012x86_*_RC_PATH = DEF(WINSDK71x86_BIN)\rc.exe
> > >
> > > *_VS2012x86_*_MAKE_FLAGS = /nologo
> > > @@ -1233,7 +1233,7 @@ NOOPT_VS2013_X64_DLINK_FLAGS = /NOLOGO
> > > /NODEFAULTLIB /IGNORE:4001 /OPT:REF /OPT
> > > *_VS2013x86_*_*_FAMILY = MSFT
> > >
> > > *_VS2013x86_*_MAKE_PATH = DEF(VS2013x86_BIN)\nmake.exe
> > > -*_VS2013x86_*_MAKE_FLAG = /nologo
> > > +*_VS2013x86_*_MAKE_FLAGS = /nologo
> > > *_VS2013x86_*_RC_PATH = DEF(WINSDK8x86_BIN)\rc.exe
> > >
> > > *_VS2013x86_*_MAKE_FLAGS = /nologo
> > > @@ -1468,7 +1468,7 @@ NOOPT_VS2015_X64_DLINK_FLAGS = /NOLOGO
> > > /NODEFAULTLIB /IGNORE:4001 /OPT:REF /OPT
> > > *_VS2015x86_*_*_FAMILY = MSFT
> > >
> > > *_VS2015x86_*_MAKE_PATH = DEF(VS2015x86_BIN)\nmake.exe
> > > -*_VS2015x86_*_MAKE_FLAG = /nologo
> > > +*_VS2015x86_*_MAKE_FLAGS = /nologo
> > > *_VS2015x86_*_RC_PATH = DEF(WINSDK81x86_BIN)\rc.exe
> > >
> > > *_VS2015x86_*_MAKE_FLAGS = /nologo
> > > @@ -1586,7 +1586,7 @@ NOOPT_VS2015x86_X64_DLINK_FLAGS =
> > > /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
> > > *_VS2017_*_*_DLL = DEF(VS2017_BIN_HOST)
> > >
> > > *_VS2017_*_MAKE_PATH = DEF(VS2017_BIN_HOST)\nmake.exe
> > > -*_VS2017_*_MAKE_FLAG = /nologo
> > > +*_VS2017_*_MAKE_FLAGS = /nologo
> > > *_VS2017_*_RC_PATH = DEF(RC_PATH)
> > >
> > > *_VS2017_*_MAKE_FLAGS = /nologo
> > > @@ -1749,7 +1749,7 @@ NOOPT_VS2017_AARCH64_DLINK_FLAGS =
> > > /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
> > > *_VS2019_*_*_DLL = DEF(VS2019_BIN_HOST)
> > >
> > > *_VS2019_*_MAKE_PATH = DEF(VS2019_BIN_HOST)\nmake.exe
> > > -*_VS2019_*_MAKE_FLAG = /nologo
> > > +*_VS2019_*_MAKE_FLAGS = /nologo
> > > *_VS2019_*_RC_PATH = DEF(RC_PATH)
> > >
> > > *_VS2019_*_MAKE_FLAGS = /nologo
> > > --
> > > 2.31.1.windows.1
> >
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74047): https://edk2.groups.io/g/devel/message/74047
Mute This Topic: https://groups.io/mt/81980992/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list