[edk2-devel] [PATCH RESEND 1/1] Platform/Arm: Fix Ecc error 7008 for SCMI_CLOCK_RATE

PierreGondois pierre.gondois at arm.com
Fri Apr 16 09:14:02 UTC 2021


From: Pierre Gondois <Pierre.Gondois at arm.com>

Following the Ecc reported error in the edk2 repository,
the SCMI_CLOCK_RATE structure has been modified in:
an enum and its elements have been renamed in:
ArmPkg/Include/Protocol/ArmScmiClockProtocol.h

This patch is a follow-up and fixes the following Ecc
reported error:
Complex types should be typedef-ed

The error is due to the a nested structure declaration.

The patch also re-formats the debug messages to fit in
a 80 chars line.

Signed-off-by: Pierre Gondois <Pierre.Gondois at arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tree/1552_Ecc_ArmPkg_BIS_v1

 .../Library/HdLcdArmJunoLib/HdLcdArmJuno.c    | 33 +++++++++++++++----
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c b/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c
index 30558878f068..67c9d43cf2b7 100644
--- a/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c
+++ b/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c
@@ -1,6 +1,6 @@
 /** @file
 
-  Copyright (c) 2013 - 2020, Arm Limited. All rights reserved.<BR>
+  Copyright (c) 2013 - 2021, Arm Limited. All rights reserved.<BR>
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -352,12 +352,31 @@ ProbeHdLcdClock (
     return Status;
   }
 
-  DEBUG ((DEBUG_ERROR, "Clock ID = %d Clock name = %a\n", *ClockId, ClockName));
-  DEBUG ((DEBUG_ERROR, "Minimum frequency = %uHz\n", ClockRate.Min));
-  DEBUG ((DEBUG_ERROR, "Maximum frequency = %uHz\n", ClockRate.Max));
-  DEBUG ((DEBUG_ERROR, "Clock rate step = %uHz\n", ClockRate.Step));
-
-  DEBUG ((DEBUG_ERROR, "HDLCD Current frequency = %uHz\n", CurrentHdLcdFreq));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Clock ID = %d Clock name = %a\n",
+    *ClockId, ClockName
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Minimum frequency = %uHz\n",
+    ClockRate.ContinuousRate.Min
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Maximum frequency = %uHz\n",
+    ClockRate.ContinuousRate.Max
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Clock rate step = %uHz\n",
+    ClockRate.ContinuousRate.Step
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "HDLCD Current frequency = %uHz\n",
+    CurrentHdLcdFreq
+    ));
 
   return EFI_SUCCESS;
 }
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74198): https://edk2.groups.io/g/devel/message/74198
Mute This Topic: https://groups.io/mt/82138139/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list