[edk2-devel] [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml

[PierreGondois]

Hi Sami,

I think the lists are already alphabetically ordered. I will re-order 
the libraries in ArmPkg.dec though.

I will remove the "eio'ed" word from the exception list in a V2.

Thanks for the review,
Pierre

On 4/22/21 11:02 AM, Sami Mujawar wrote:
>
> Hi Pierre,
>
> I have a few minor comments marked inline as [SAMI].
>
> With those changed.
>
> Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>
>
> Regards,
>
> Sami Mujawar
>
> *From: *Pierre.Gondois at arm.com <Pierre.Gondois at arm.com>
> *Date: *Wednesday, 21 April 2021 at 13:21
> *To: *devel at edk2.groups.io <devel at edk2.groups.io>, Sami Mujawar 
> <Sami.Mujawar at arm.com>, leif at nuviainc.com <leif at nuviainc.com>, 
> ardb+tianocore at kernel.org <ardb+tianocore at kernel.org>, 
> sean.brogan at microsoft.com <sean.brogan at microsoft.com>, 
> Bret.Barkelew at microsoft.com <Bret.Barkelew at microsoft.com>
> *Subject: *[PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml
>
> From: Pierre Gondois <Pierre.Gondois at arm.com>
>
> Add ArmPkg.ci.yaml to configure the CI for the
> ArmPkg.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois at arm.com>
> ---
>  ArmPkg/ArmPkg.ci.yaml | 222 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 222 insertions(+)
>  create mode 100644 ArmPkg/ArmPkg.ci.yaml
>
> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
> new file mode 100644
> index 000000000000..ba502cd647c9
> --- /dev/null
> +++ b/ArmPkg/ArmPkg.ci.yaml
> @@ -0,0 +1,222 @@
> +## @file
> +# CI configuration for ArmPkg
> +#
> +# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +{
> +    ## options defined .pytool/Plugin/LicenseCheck
> +    "LicenseCheck": {
> +        "IgnoreFiles": []
> +    },
> +
> +    "EccCheck": {
> +        ## Exception sample looks like below:
> +        ## "ExceptionList": [
> +        ##     "<ErrorID>", "<KeyWord>"
> +        ## ]
> +        "ExceptionList": [
> +        ],
> +        ## Both file path and directory path are accepted.
> +        "IgnoreFiles": [
> +            "Library/ArmSoftFloatLib/berkeley-softfloat-3"
> +        ]
> +    },
> +
> +    ## options defined .pytool/Plugin/CompilerPlugin
> +    "CompilerPlugin": {
> +        "DscPath": "ArmPkg.dsc"
> +    },
> +
> +    ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
> +    "HostUnitTestCompilerPlugin": {
> +        "DscPath": "" # Don't support this test
> +    },
> +
> +    ## options defined .pytool/Plugin/CharEncodingCheck
> +    "CharEncodingCheck": {
> +        "IgnoreFiles": []
> +    },
> +
> +    ## options defined .pytool/Plugin/DependencyCheck
> +    "DependencyCheck": {
> +        "AcceptableDependencies": [
> +            "ArmPlatformPkg/ArmPlatformPkg.dec",
> +            "ArmPkg/ArmPkg.dec",
> +            "EmbeddedPkg/EmbeddedPkg.dec",
> +            "MdeModulePkg/MdeModulePkg.dec",
> +            "MdePkg/MdePkg.dec",
> +            "ShellPkg/ShellPkg.dec"
>
> [SAMI] Can this list be sorted in alphabetical order, please?
>
> [/SAMI]
> +        ],
> +        # For host based unit tests
> +        "AcceptableDependencies-HOST_APPLICATION":[
> +            "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
> +        ],
> +        # For UEFI shell based apps
> +        "AcceptableDependencies-UEFI_APPLICATION":[],
> +        "IgnoreInf": []
> +    },
> +
> +    ## options defined .pytool/Plugin/DscCompleteCheck
> +    "DscCompleteCheck": {
> +        "IgnoreInf": [],
> +        "DscPath": "ArmPkg.dsc"
> +    },
> +
> +    ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
> +    "HostUnitTestDscCompleteCheck": {
> +        "IgnoreInf": [""],
> +        "DscPath": "" # Don't support this test
> +    },
> +
> +    ## options defined .pytool/Plugin/GuidCheck
> +    "GuidCheck": {
> +        "IgnoreGuidName": [],
> +        "IgnoreGuidValue": [],
> +        "IgnoreFoldersAndFiles": [],
> +        "IgnoreDuplicates": [],
> +    },
> +
> +    ## options defined .pytool/Plugin/LibraryClassCheck
> +    "LibraryClassCheck": {
> +        "IgnoreHeaderFile": []
> +    },
> +
> +    ## options defined .pytool/Plugin/SpellCheck
> +    "SpellCheck": {
> +        "AuditOnly": False,
> +        "IgnoreFiles": [
> + "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"
> +        ],                           # use gitignore syntax to ignore 
> errors
> +                                     # in matching files
> +        "ExtendWords": [
> +          "api's",
> +          "ackintid",
>
> [SAMI] Can this list be sorted in alphabetical order, please?
>
> [/SAMI]
> +          "actlr",
> +          "aeabi",
> +          "ashldi",
> +          "ashrdi",
> +          "ccidx",
> +          "ccsidr",
> +          "clidr",
> +          "clrex",
> +          "clzsi",
> +          "cpuactlr",
> +          "csselr",
> +          "ctzsi",
> +          "cygdrive",
> +          "cygpaths",
> +          "datas",
> +          "dcmpeq",
> +          "dcmpge",
> +          "dcmpgt",
> +          "dcmple",
> +          "dcmplt",
> +          "ddisable",
> +          "divdi",
> +          "divsi",
> +          "dmdepkg",
> +          "drsub",
> +          "eoi'ed",
>
> [SAMI] I don’t think there is such a word. Should the original text be 
> fixed?
>
> [/SAMI]
> +          "fcmpeq",
> +          "fcmpge",
> +          "fcmpgt",
> +          "fcmple",
> +          "fcmplt",
> +          "ffreestanding",
> +          "frsub",
> +          "hisilicon",
> +          "iccbpr",
> +          "icciar",
> +          "iccicr",
> +          "icciidr",
> +          "iccpmr",
> +          "icdicer",
> +          "icdicfr",
> +          "icdictr",
> +          "icdiser",
> +          "icdisr",
> +          "icdsgir",
> +          "icenabler",
> +          "intid",
> +          "ipriority",
> +          "irouter",
> +          "isenabler",
> +          "istatus",
> +          "itargets",
> +          "lable",
> +          "ldivmod",
> +          "ldmdb",
> +          "ldmia",
> +          "ldrbt",
> +          "ldrex",
> +          "ldrexb",
> +          "ldrexd",
> +          "ldrexh",
> +          "ldrhbt",
> +          "ldrht",
> +          "ldrsb",
> +          "ldrsbt",
> +          "ldrsh",
> +          "lshrdi",
> +          "moddi",
> +          "modsi",
> +          "mpidr",
> +          "muldi",
> +          "mullu",
> +          "nonshareable",
> +          "nsacr",
> +          "nsasedis",
> +          "nuvia",
> +          "oldit",
> +          "readc",
> +          "revsh",
> +          "rfedb",
> +          "sctlr",
> +          "smccc",
> +          "smlabb",
> +          "smlabt",
> +          "smlad",
> +          "smladx",
> +          "smlatb",
> +          "smlatt",
> +          "smlawb",
> +          "smlawt",
> +          "smlsd",
> +          "smlsdx",
> +          "smmla",
> +          "smmlar",
> +          "smmls",
> +          "smmlsr",
> +          "sourcery",
> +          "srsdb",
> +          "stmdb",
> +          "stmia",
> +          "strbt",
> +          "strexb",
> +          "strexd",
> +          "strexh",
> +          "strht",
> +          "switchu",
> +          "tpidrurw",
> +          "ttbcr",
> +          "typer",
> +          "ucmpdi",
> +          "udivdi",
> +          "udivmoddi",
> +          "udivsi",
> +          "uefi's",
> +          "uldiv",
> +          "umoddi",
> +          "umodsi",
> +          "usada",
> +          "vlpis",
> +          "writec"
> +        ],                          # words to extend to the 
> dictionary for this package
> +        "IgnoreStandardPaths": [    # Standard Plugin defined paths that
> +            "*.asm", "*.s"          # should be ignore
> +        ],
> +        "AdditionalIncludePaths": [] # Additional paths to spell check
> +                                     # (wildcards supported)
> +    }
> +}
> -- 
> 2.17.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74470): https://edk2.groups.io/g/devel/message/74470
Mute This Topic: https://groups.io/mt/82258507/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-