[edk2-devel][PATCH v3 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib

[Ni, Ray]

> +#include <PiPei.h>
> +#include <Uefi.h>

1. can you please check whether <BaseTypes.h> is enough?

> +VOID
> +EFIAPI
> +ReportCpuHob (
> +  VOID
> +  );

2. can you please add comments for this API in header file and C file?

> 
> +    AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &RegEax, NULL, NULL, NULL);

3. can you use CPUID_VIR_PHY_ADDRESS_SIZE_EAX AddressSizeEax?
So the code becomes:
AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &AddressSizeEax.Uint32, NULL, NULL, NULL);
BuildCpuHob (AddressSizeEax.Bits.PhysicalAddressBits, 16);



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74513): https://edk2.groups.io/g/devel/message/74513
Mute This Topic: https://groups.io/mt/82403553/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-