Re: [edk2-devel] 回复: [edk2-platforms PATCH v6 0/4] Secure Boot default keys

Wed Aug 4 12:33:12 UTC 2021

On Wed, 4 Aug 2021 at 04:21, gaoliming <gaoliming at byosoft.com.cn> wrote:
>
> Sunny:
>   I am OK to merge the reviewed patched first.
>

Patches 2-4 merged as 2f0188b56ef4..5ba08a9b7516

Thanks all


> > -----邮件原件-----
> > 发件人: Sunny Wang <Sunny.Wang at arm.com>
> > 发送时间: 2021年8月3日 22:11
> > 收件人: Grzegorz Bernacki <gjb at semihalf.com>; devel at edk2.groups.io;
> > ardb+tianocore at kernel.org
> > 抄送: leif at nuviainc.com; Samer El-Haj-Mahmoud
> > <Samer.El-Haj-Mahmoud at arm.com>; mw at semihalf.com;
> > upstream at semihalf.com; jiewen.yao at intel.com; jian.j.wang at intel.com;
> > min.m.xu at intel.com; lersek at redhat.com; Sami Mujawar
> > <Sami.Mujawar at arm.com>; afish at apple.com; ray.ni at intel.com;
> > jordan.l.justen at intel.com; rebecca at bsdio.com; grehan at freebsd.org;
> > Thomas Abraham <thomas.abraham at arm.com>; chasel.chiu at intel.com;
> > nathaniel.l.desimone at intel.com; gaoliming at byosoft.com.cn;
> > eric.dong at intel.com; michael.d.kinney at intel.com; zailiang.sun at intel.com;
> > yi.qian at intel.com; graeme at nuviainc.com; rad at semihalf.com; pete at akeo.ie;
> > Sunny Wang <Sunny.Wang at arm.com>
> > 主题: RE: [edk2-platforms PATCH v6 0/4] Secure Boot default keys
> >
> > Hi Ard and Maintainers,
> >
> > For this patchset,
> >  1/4 - Intel Platforms: add SecureBootVariableLib class resolution
> >  2/4 - ARM Silicon and Platforms: add SecureBootVariableLib class
> resolution
> >  3/4 - RISC-V Platforms: add SecureBootVariableLib class resolution
> >  4/4 - Platform/RaspberryPi: Enable default Secure Boot variables
> > initialization
> >
> > Only Intel platform patch (1/4) hasn't got all Review-bys. I offline sent
> a
> > reminder to Intel platform Maintainers. I think they may be busy with
> other
> > things or need more time to review it.
> >
> > Therefore, how about we merge another three patches (2/4, 3/4, and 4/4)
> > first?
> >
> > Best Regards,
> > Sunny Wang
> >
> > -----Original Message-----
> > From: Grzegorz Bernacki <gjb at semihalf.com>
> > Sent: Wednesday, July 14, 2021 8:31 PM
> > To: devel at edk2.groups.io
> > Cc: leif at nuviainc.com; ardb+tianocore at kernel.org; Samer El-Haj-Mahmoud
> > <Samer.El-Haj-Mahmoud at arm.com>; Sunny Wang <Sunny.Wang at arm.com>;
> > mw at semihalf.com; upstream at semihalf.com; jiewen.yao at intel.com;
> > jian.j.wang at intel.com; min.m.xu at intel.com; lersek at redhat.com; Sami
> > Mujawar <Sami.Mujawar at arm.com>; afish at apple.com; ray.ni at intel.com;
> > jordan.l.justen at intel.com; rebecca at bsdio.com; grehan at freebsd.org;
> > Thomas Abraham <thomas.abraham at arm.com>; chasel.chiu at intel.com;
> > nathaniel.l.desimone at intel.com; gaoliming at byosoft.com.cn;
> > eric.dong at intel.com; michael.d.kinney at intel.com; zailiang.sun at intel.com;
> > yi.qian at intel.com; graeme at nuviainc.com; rad at semihalf.com; pete at akeo.ie;
> > Grzegorz Bernacki <gjb at semihalf.com>
> > Subject: [edk2-platforms PATCH v6 0/4] Secure Boot default keys
> >
> > This patchset is a consequence of "Secure Boot default keys"
> > patchset in edk2. It adds SecureBootVariableLib class resolution
> > for each platform which uses SecureBootConfigDxe and also
> > enables Secure Boot variables initialization for RPi4.
> > Previously these commits were part of edk2 patchset, but since
> > number of commits increased in v5 version, it is now separate
> > patchset.
> >
> > Changes related to both edk2 & edk-platform versions:
> > Changes since v1:
> > - change names:
> >   SecBootVariableLib => SecureBootVariableLib
> >   SecBootDefaultKeysDxe => SecureBootDefaultKeysDxe
> >   SecEnrollDefaultKeysApp => EnrollFromDefaultKeysApp
> > - change name of function CheckSetupMode to GetSetupMode
> > - remove ShellPkg dependecy from EnrollFromDefaultKeysApp
> > - rebase to master
> >
> > Changes since v2:
> > - fix coding style for functions headers in SecureBootVariableLib.h
> > - add header to SecureBootDefaultKeys.fdf.inc
> > - remove empty line spaces in SecureBootDefaultKeysDxe files
> > - revert FAIL macro in EnrollFromDefaultKeysApp
> > - remove functions duplicates and  add SecureBootVariableLib
> >   to platforms which used it
> >
> > Changes since v3:
> > - move SecureBootDefaultKeys.fdf.inc to ArmPlatformPkg
> > - leave duplicate of CreateTimeBasedPayload in PlatformVarCleanupLib
> > - fix typo in guid description
> >
> > Changes since v4:
> > - reorder patches to make it bisectable
> > - split commits related to more than one platform
> > - move edk2-platform commits to separate patchset
> >
> > Changes since v5:
> > - split SecureBootVariableLib into SecureBootVariableLib and
> >   SecureBootVariableProvisionLib
> >
> > Grzegorz Bernacki (4):
> >   Intel Platforms: add SecureBootVariableLib class resolution
> >   ARM Silicon and Platforms: add SecureBootVariableLib class resolution
> >   RISC-V Platforms: add SecureBootVariableLib class resolution
> >   Platform/RaspberryPi: Enable default Secure Boot variables
> >     initialization
> >
> >  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> > | 2 ++
> >  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > | 2 ++
> >  Platform/Intel/QuarkPlatformPkg/Quark.dsc
> > | 2 ++
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> > | 2 ++
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> > | 2 ++
> >  Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> > | 2 ++
> >  Platform/RaspberryPi/RPi3/RPi3.dsc
> > | 2 ++
> >  Platform/RaspberryPi/RPi4/RPi4.dsc
> > | 4 ++++
> >  Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> > | 2 ++
> >
> > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> > | 2 ++
> >  Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > | 5 +++++
> >  Platform/RaspberryPi/RPi4/RPi4.fdf
> > | 2 ++
> >  12 files changed, 29 insertions(+)
> >
> > --
> > 2.25.1
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> > confidential and may also be privileged. If you are not the intended
> recipient,
> > please notify the sender immediately and do not disclose the contents to
> any
> > other person, use it for any purpose, or store or copy the information in
> any
> > medium. Thank you.
>
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78642): https://edk2.groups.io/g/devel/message/78642
Mute This Topic: https://groups.io/mt/84654266/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-