[edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h

[Abner Chang]

> -----Original Message-----
> From: Leif Lindholm [mailto:leif at nuviainc.com]
> Sent: Wednesday, August 4, 2021 8:34 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang at hpe.com>
> Cc: devel at edk2.groups.io; Schaefer, Daniel <daniel.schaefer at hpe.com>;
> Ard Biesheuvel <ard.biesheuvel at arm.com>; Anup Patel
> <anup.patel at wdc.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp
> and strncpy to libfdt_env.h
> 
> Gah, sorry.
> 
> The original patch landed while I was distracted, and this reminder
> while I was on holiday.
Thanks, will correct the subject before merging it.

> 
> Apart from the typo in the subject line, I guess I'm OK with this.
> Acked-by: Leif Lindholm <leif at nuviainc.com>
> 
> However, I have a feeling RISC-V will be updating EmbeddedPkg as
> frequently as ARM in the near future.
> Could we add one or both of you as maintainers?
Sure, we can be the  maintainers of EmbeddedPkg.

I can send out the patch of maintainers.txt first and then merge this patch later.
Thanks
Abner


> 
> /
>     Leif
> 
> On Wed, Jul 14, 2021 at 14:05:53 +0000, Chang, Abner (HPS SW/FW
> Technologist) wrote:
> > Hi Leif and Ard,
> > Please help to review this and merge it if you have no comments on this
> patch.
> >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf
> Of
> > > Abner Chang
> > > Sent: Wednesday, May 19, 2021 11:30 PM
> > > To: Schaefer, Daniel <daniel.schaefer at hpe.com>; devel at edk2.groups.io
> > > Cc: Leif Lindholm <leif at nuviainc.com>; Ard Biesheuvel
> > > <ard.biesheuvel at arm.com>; Anup Patel <anup.patel at wdc.com>
> > > Subject: Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add
> strmp
> > > and strncpy to libfdt_env.h
> > >
> > > Reviewed-by: Abner Chang <abner.chang at hpe.com>
> > >
> > > > -----Original Message-----
> > > > From: Schaefer, Daniel
> > > > Sent: Wednesday, May 19, 2021 10:58 PM
> > > > To: devel at edk2.groups.io
> > > > Cc: Chang, Abner (HPS SW/FW Technologist) <abner.chang at hpe.com>;
> > > Leif
> > > > Lindholm <leif at nuviainc.com>; Ard Biesheuvel
> > > <ard.biesheuvel at arm.com>;
> > > > Anup Patel <anup.patel at wdc.com>
> > > > Subject: [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to
> > > > libfdt_env.h
> > > >
> > > > OpenSBI has started using those in v0.9. See:
> > > > https://github.com/riscv/opensbi/blob/v0.9/lib/utils/fdt/fdt_domain.c
> > > >
> > > > Cc: Abner Chang <abner.chang at hpe.com>
> > > > Cc: Leif Lindholm <leif at nuviainc.com>
> > > > Cc: Ard Biesheuvel <ard.biesheuvel at arm.com>
> > > > Cc: Daniel Schaefer <daniel.schaefer at hpe.com>
> > > > Cc: Anup Patel <anup.patel at wdc.com>
> > > > Signed-off-by: Daniel Schaefer <daniel.schaefer at hpe.com>
> > > > ---
> > > >  EmbeddedPkg/Include/libfdt_env.h | 8 ++++++++
> > > >  1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/EmbeddedPkg/Include/libfdt_env.h
> > > > b/EmbeddedPkg/Include/libfdt_env.h
> > > > index 7feff52bc0fb..c35ac739703c 100644
> > > > --- a/EmbeddedPkg/Include/libfdt_env.h
> > > > +++ b/EmbeddedPkg/Include/libfdt_env.h
> > > > @@ -76,8 +76,16 @@ static inline size_t strnlen (const char* str, size_t
> > > strsz ) {
> > > >    return AsciiStrnLenS (str, strsz);
> > > >
> > > >  }
> > > >
> > > >
> > > >
> > > > +static inline size_t strcmp (const char* str1, const char* str2) {
> > > >
> > > > +  return AsciiStrCmp (str1, str2);
> > > >
> > > > +}
> > > >
> > > > +
> > > >
> > > >  static inline size_t strncmp (const char* str1, const char* str2, size_t
> strsz )
> > > {
> > > >
> > > >    return AsciiStrnCmp (str1, str2, strsz);
> > > >
> > > >  }
> > > >
> > > >
> > > >
> > > > +static inline size_t strncpy (char* dest, const char* source, size_t
> > > dest_max) {
> > > >
> > > > +  return AsciiStrCpyS (dest, dest_max, source);
> > > >
> > > > +}
> > > >
> > > > +
> > > >
> > > >  #endif /* _LIBFDT_ENV_H */
> > > >
> > > > --
> > > > 2.30.1
> > >
> > >
> > >
> > > 
> > >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78644): https://edk2.groups.io/g/devel/message/78644
Mute This Topic: https://groups.io/mt/82938220/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-