[edk2-devel] [PATCH V4 3/3] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf

[Min Xu]

On August 4, 2021 6:01 PM, Erdem Aktas wrote:
> I agree with Brijesh on that this patch should be divided into smaller ones.
In Brijesh's comments he will help to do following:
1. introduce the updated CcWorkArea structure 
2. update the existing code to use the CcWorkArea layout
Based on his patch, I will rework my patch.
> 
> On Mon, Aug 2, 2021 at 6:18 PM Min Xu <min.m.xu at intel.com> wrote:
> >
> > +    ;
> > +    ; EBP[6:0] CPU supported GPA width
> > +    ;
> > +    and     ebp, 0x3f
> 
> Based on
> https://software.intel.com/content/dam/develop/external/us/en/documents
> /tdx-module-1eas-v0.85.039.pdf
>  sec 8.1.2
> Is not this EBP[5:0] for GPA width ? it should be "and ebp, 0x1f"
Ah, yes, it should be EBP[5:0] for GPA width.
"and ebp, 0x3f" is correct. GPAW is in the lowest 6 bit.
> 

Thanks
Xu, Min


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78645): https://edk2.groups.io/g/devel/message/78645
Mute This Topic: https://groups.io/mt/84631106/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-