[edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/AcpiPlatform: Set X_GPE1_BLK GAS structure to zeroes

Michael Kubacki mikuback at linux.microsoft.com
Thu Aug 5 16:38:15 UTC 2021


From: Michael Kubacki <michael.kubacki at microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3534

Updates the code to be compatible with a recent Firmware Test Suite
(FWTS) fix that improves adherence to the ACPI Specification.

Relevant FWTS commit:
https://git.launchpad.net/fwts/commit/?
id=4ad3e374bf98931c84adcf6e523982b5ebb83748

Cc: Chasel Chiu <chasel.chiu at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>
Cc: Eric Dong <eric.dong at intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki at microsoft.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 6919e3196143..fe57ec4f7bb7 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1321,7 +1321,8 @@ PlatformUpdateTables (
     FadtHeader->XGpe0Blk.Address    = PcdGet16 (PcdAcpiGpe0BlockAddress);
     FadtHeader->XGpe1Blk.Address    = PcdGet16 (PcdAcpiGpe1BlockAddress);
     if (FadtHeader->XGpe1Blk.Address == 0) {
-      FadtHeader->XGpe1Blk.AccessSize = 0;
+      FadtHeader->XGpe1Blk.AddressSpaceId = 0;
+      FadtHeader->XGpe1Blk.AccessSize     = 0;
     }
 
     DEBUG(( EFI_D_ERROR, "ACPI FADT table @ address 0x%x\n", Table ));
-- 
2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78743): https://edk2.groups.io/g/devel/message/78743
Mute This Topic: https://groups.io/mt/84688771/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list